workaround for python3.5 UTs build setup and replace assert_called_once mock method #3191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python3.5 setup fails with invalid ssl cert while fetching pip ( Could not fetch URL https://pypi.python.org/simple/pip/: There was a problem confirming the ssl certificate: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:728) - skipping)
Added workaround for it as mentioned on this thread actions/setup-python#866
This pr also addresses some of the unit tests failing on python3.5 due to assert_called_once attribute not found error and same thing, we saw it in container as well
I found out that assert_called_once is not available before < 3.6 and using this will produce unexpected behavior. It seems we should avoid using as per this https://web.archive.org/web/20210919045841/http://engineroom.trackmaven.com/blog/mocking-mistakes/
https://web.archive.org/web/20211009193419/https://docs.python.org/3.5/library/unittest.mock.html
https://stackoverflow.com/questions/42297549/magic-mock-assert-called-once-vs-assert-called-once-with-weird-behaviour
Issue #
PR information
Quality of Code and Contribution Guidelines