Fix pytest warnings #3084
Merged
Fix pytest warnings #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
narrieta
commented
Mar 7, 2024
| @@ -6,7 +6,7 @@ | |||
| from tests.lib.tools import AgentTestCase, clear_singleton_instances | |||
|
|
|||
|
|
|||
| class TestClassToTestSingletonPerThread(SingletonPerThread): | |||
There was a problem hiding this comment.
Renamed this, since pytest was identifying it as a Test class
narrieta
commented
Mar 7, 2024
| @@ -156,8 +156,6 @@ def setUpClass(cls): | |||
| cls.assertIsNone = cls.emulate_assertIsNone | |||
| if not hasattr(cls, "assertIsNotNone"): | |||
| cls.assertIsNotNone = cls.emulate_assertIsNotNone | |||
| if hasattr(cls, "assertRaisesRegexp"): | |||
There was a problem hiding this comment.
I guess this was needed for some old Python versions, but it is no longer needed, and it is producing a warning about assertRaisesRegexp being deprecated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3084 +/- ##
========================================
Coverage 71.89% 71.89%
========================================
Files 110 110
Lines 16395 16395
Branches 2342 2342
========================================
Hits 11788 11788
Misses 4055 4055
Partials 552 552 ☔ View full report in Codecov by Sentry. |
maddieford
approved these changes
Mar 7, 2024
nagworld9
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing pytest warnings; most of them were due to strings representing regular expressions missing the 'r' prefix (we were suppressing those from pylint).