Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry on agent cgroups tracking check #3062

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

nagworld9
Copy link
Contributor

Description

Timing issue for agent cgroups tracking check. Added retry
Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e83971) 71.91% compared to head (9e0fe4d) 71.91%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3062   +/-   ##
========================================
  Coverage    71.91%   71.91%           
========================================
  Files          109      109           
  Lines        16357    16357           
  Branches      2337     2337           
========================================
  Hits         11763    11763           
  Misses        4044     4044           
  Partials       550      550           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maddieford
maddieford previously approved these changes Feb 21, 2024
@narrieta
Copy link
Member

@nagworld9
Timing issue for agent cgroups tracking check.
Could you describe what the timing issue is?

@nagworld9
Copy link
Contributor Author

@narrieta We check if agent tracking agent cgroups. Tracking is done part of agent cgroupconfiguarator. The test check is happening before the cgroupconfiguarator code execute.

@narrieta
Copy link
Member

@nagworld9 thanks, we should add that as a comment in the test

@nagworld9 nagworld9 merged commit f27b7b2 into Azure:develop Feb 22, 2024
12 checks passed
@nagworld9 nagworld9 deleted the cgroups-retry branch February 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants