Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.123.0 - stagingmaster #10652

Merged
merged 40 commits into from
Jul 8, 2024
Merged

Release v1.123.0 - stagingmaster #10652

merged 40 commits into from
Jul 8, 2024

Conversation

dwiley-akamai
Copy link
Contributor

Cloud Manager

[2024-07-08] - v1.123.0

Added:

  • Design Tokens (CDS 2.0) (#10022)
  • Design update dismissible banner (#10640)

Changed:

  • Rebuild Linode drawer (#10594)
  • Auto-populate Image label based on Linode and Disk names (#10604)
  • Update Linode disk action menu (#10614)

Fixed:

  • Potential runtime issue with conditional hook (#10584)
  • Visual bug inside Node Pools table (#10599)
  • Linode Resize dialog UX when linode data is loading or there is an error (#10618)

Removed:

  • Region helper text on the Image Upload page (#10642)

Tech Stories:

  • Refactor SupportTicketDialog with React Hook Form (#10557)
  • Query Key Factory for ACLB (#10598)
  • Make Factory.each start incrementing at 1 instead of 0 (#10619)

Tests:

  • Cypress integration test for SSH key update and delete (#10542)
  • Refactor Cypress Longview test to use mock API data/events (#10579)
  • Add assertions for created LKE cluster in Cypress LKE tests (#10593)
  • Update Object Storage tests to mock account capabilities as needed for Multicluster (#10602)
  • Fix OBJ test failure caused by visiting hardcoded and out-of-date URL (#10609)
  • Combine VPC details page subnet create, edit, and delete Cypress tests (#10612)
  • De-parameterize Cypress Domain Record Create tests (#10615)
  • De-parameterize Cypress Deep Link smoke tests (#10622)
  • Improve security of Linodes created during tests (#10633)

Upcoming Features:

  • Gecko GA Region Select (#10479)
  • Add Dashboard Selection component inside the Global Filters of CloudPulse view (#10589)
  • Conditionally disable regions based on the selected image on Linode Create (#10607)
  • Prevent Linode Create v2 from toggling mid-creation (#10611)
  • Add new search query parser to Linode Create v2 StackScripts tab (#10613)
  • Add ‘Manage Image Regions’ Drawer (#10617)
  • Add Marketplace Cluster pricing support to Linode Create v2 (#10623)
  • Add debouncing to the Linode Create v2 VLANSelect (#10628)
  • Add Validation to Linode Create v2 Marketplace Tab (#10629)
  • Add Image distributed compatibility notice to Linode Create (#10636)

API-v4

[2024-07-08] - v0.121.0

Changed:

  • Update updateImageRegions to accept UpdateImageRegionsPayload instead of regions: string[] (#10617)

Upcoming Features:

  • Added types needed for DashboardSelect component (#10589)

Validation

[2024-07-08] - v0.49.0

Added:

  • createSMTPSupportTicketSchema to support schemas (#10557)

bnussman-akamai and others added 30 commits June 21, 2024 12:34
…eeded (#10602)

* mock account capabilities as needed

* Added changeset: Update Object Storage tests to mock account capabilities as needed for multi cluster

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…/events (#10579)

* update tests for check longview install with mock data

* Update tests

* Added changeset: Refactor Cypress Longview test to use mock API data/events

* update according to the review

* update after reviews
* Add design tokens

* Updates to status colors

* Saving...

* Saving...

* Version 14

* Update version to v1.0.0

* Added changeset: Added Design Tokens (CDS 2.0)

* Update to latest version

* Revert

* Bump version

* Updates to chip palette and update endpoint palette to use darker error color

* Remove unnecessary background color for notice story

* Update textfields, borders and outlines

* Fix dark mode button

* Revert input token changes

* Revert border tokens and fix marketplace background

* Fix darkmode

* Dark mode tokens

* More dark mode fixes

* Update MuiFormHelperText dark mode color

* Yarn lock

* fix units

* Fix disabled buttons

* Saving

* Saving...

* Adjust billing paper

* Work in progress

* More style updates

* Minor

* Add feature flag

* More updates

* Modal close

* Nearing the end

* update snapshots

* Snaclbar and placeholder update

* Tefield updates dark theme

* Update to menu items

* react select placeholder

* feedback @dwiley-akamai

* feedback

* Revert nav hover colors back to Linode green

* last feedback bit

---------

Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Co-authored-by: Alban Bailly <abailly@akamai.com>
* Saving progress...

* Add compatibility, total size and image id columns

* Add onManageRegions to image action menu

* Add unit tests for ImagesLanding

* Add mock regions image and improve conditional column rendering

* remove extraneous changes

* Add more unit tests

* Added changeset: Update Images Landing table

* Suppress typechecker warnings

* Prevent crashing when `.regions` field is not present

* Remove sorting on image ID

* MSW: respect image type filter

* New RegionsList component and tests

* Image Id -> Image ID

* Hide columns in md breakpoint

* Re-organize Images directory

* Fix unit test

* Update drawer and unit tests

* Use DescriptionList

* Added changeset: Rebuild Linode drawer

* Add `imageServiceGen2`feature flag

* Remove conditional render for drawer

* Convert ImageRow to named export

* Fix unit test

* Update unit tests to check for image label render
…l filters view (#10589)

* upcoming: [DI-19062] - Dashboard Select component in cloudpulse global filters view

* upcoming: [DI-19062] - Added change set

* upcoming: [DI-19062] - Replaced the hard-coded url with placeholder

* upcoming: [DI-19062] - Updated placeholder in dashboard select component

* upcoming: [DI-19062] - Added test cases
…d test (#10609)

* Account for OBJ Multicluster in object upload test

* Added changeset: Fix OBJ test failure caused by visiting hardcoded and out-of-date URL
…cted image (#10607)

* initial work to disable regions based on image

* add unit test

* Added changeset: Conditionally disable regions based on the selected image on Linode Create

* adjust based on incorrect ux mocks

* update copy

* comments

* fix linode create v1 bug where image defaults to debian 11 on images tab

* feedback @hkhalil-akamai

* change copy to `a distributed region`, add unit test for Linode Create v1 @abailly-akamai

* use shared util for both flows and unit test new util @abailly-akamai

* fix typo

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…k Form (#10557)

* Save work

* WIP - clean up constants, convert general ticket to RHF

* Clean up and save work

* Fix onSubmit

* Fix entity and severity selection

* Add back SMTP fields to support ticket form

* Fix unrelated Support Ticket Landing table loading state bug

* Put entity-related-fields in their own component

* Improve description formatting and add util test coverage

* Revert "Improve description formatting and add util test coverage"

This reverts commit 8797577.

* Lint

* Refactor formatDescription util

* Add test coverage for formatDescription util

* Use new formatDescription function to set the ticket description

* Extend SMTP interface and map from generic custom fields interface and map

* Update interface name; set SMTP form with all default values

* Add validation schema for SMTP fields

* Attempt to fix highlight.js error

* Clean up constants

* Import formatDescription util from utils file

* Add file upload

* Add SMTP integration test with a TODO

* Fix bugs caught by failing SMTP integration test

* Oops, remove .only

* Improve comments

* Attempt to replace scrollErrorIntoView

* Reset drawer state from localStorage if closed accidentally

* Goodbye old friend

* More clean up and more accurate test coverage

* Clean up resetTicket

* Fix submitting state and drawer reset happening too soon

* Add changesets

* Fix local storage issues and save all general form data

* Revert "Fix local storage issues and save all general form data"

This reverts commit c205bc8.

* Address feedback: entity error not surfacing and add test coverage

* Fix a styling regression from Design Tokens

* Actual styling fix for description spacing
* complete certificates, configurations, and loadbalancers

* finish refactor

* Added changeset: Query Key Factory for ACLB

* fix `mutationFn`

* invalidate nested relationsips

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
## Description 📝
Add tabbed Core/Distributed Region select for the Linode Create flow for Gecko GA. Since distributed regions are in a separate tab, there is no need to display the distributed icon. The region label also now displays Country, City with the slug id right aligned

_Note: Regions in other areas of the app may still display as City, State. This will be addressed separately in M3-8209_

## Changes  🔄
- Added tabbed Core/Distributed Region select in the Linode Create flow
- Hide distributed icon for Gecko GA
- Display region label as Country, City instead of City, State
- Region slug id is now right aligned

## How to test 🧪

### Prerequisites
- Ensure your account has the `new-dc-testing`, `edge_testing` and `edge_compute` customer tags

### Verification steps
- Go to the Linode Create flow, the Region section should now have two tabs, `Core` and `Distributed`
- The region select options for both Core and Distributed should display as Country, City with the slug id right aligned
- The region select options for the Core tab should only show regions with a `site_type` of `core`
  - Selecting a core region should display Linode plans as normal
- The region select options for the Distributed tab should only show regions with a `site_type` of `distributed`
  - Additionally, users can filter distributed regions by geographical area. The geographical area should default to `All`
  - Selecting a geographical area should filter the region select for regions in the geographical area. If `All` is selected, display all distributed regions
  - Selecting a distributed region should show the distributed plan table with warning notice about pricing
- The tabbed regions should not display if the customer does not have the customer tags
- Ensure that Gecko Beta still functions as expected. We want to be able to toggle between Beta and GA seamlessly.
  - Comment out the hard coded gecko2 test values in `useFlags.ts` and in the devtools click on `Reset to LD default flags`

```
yarn test RegionSelect.utils
```

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…k names (#10604)

* Auto-populate Image Label based on linode and disk names

* Update unit tests

* Added changeset: Auto-populate Image label based on Linode and Disk names

* Feedback @bnussman-akamai

* Fix e2e tests

* Fix unit test

* Revert 'Image Label' change
…10615)

* Consolidate domain records tests into a single test

* Add changeset

* Update variable names and remove string interpolation
* Make changes linode disk menu, clean up components and add unit tests

* Fix unit test

* Added changeset: Update Linode disk action menu

* Remove errant call to debug()

* feedback @bnussman-akamai

* Change action menu item from 'Cancel Upload' to 'Cancel'
* Combine parameterized tests into single test

* Add changeset
…10619)

* Initial commit - save work

* save progress

* save progress

* last one

* comment and cleanup

* cleanup

* Added changeset: Enforce Factory.each to start increment at 1

* exclude cypress for now

* comment

* Going the proxy route in order to satisfy cypress

* feedback @dwiley-akamai @mjac0bs

* Remove hard-coded plan type labels in test assertions

* feedback @bnussman-akamai

* small cleanup

---------

Co-authored-by: Joe D'Amore <jdamore@linode.com>
…ools Table (#10599)

* Fix alignment issue of the IP Address in Node Pools table

* Add changeset

* Implement PR feedback

* More PR feedback

* Comment out gecko2 mock flags causing clone-linode spec to fail
* initial poc of quietly introducing search v2

* undo volumes changes

* undo stackscript changes

* use new parser on Linode Create v2

* order imports

* add licence

* fix vitest failure

* test new package in ci

* Added changeset: Add new search query parser to Linode Create v2 StackScripts tab

* feedback @abailly-akamai

* feedback @abailly-akamai

* fix spelling

* fix grammar option

* feedback @dwiley-akamai

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…tion (#10611)

* hold flag value in state so it does not change

* Added changeset: Prevent Linode Create v2 from toggling mid-creation

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…Tab (#10629)

* add validation for marketplace tab

* Added changeset: Add Validation to Linode Create v2 Marketplace Tab

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
## Description 📝
Looks like there was a change made to the `isDistributedRegionSupported` function which caused a regression in the distributed regions displaying in the Linode Create flow

## How to test 🧪

### Prerequisites
(How to setup test environment)
- Ensure your account has the `new-dc-testing`, `edge_testing` and `edge_compute` customer tags

### Reproduction steps
(How to reproduce the issue, if applicable)
- Go to the remote dev environment and observe no Distributed regions in the Linode Create flow

### Verification steps
(How to verify changes)
- Either locally or in the preview link, go to the Linode Create flow. Distributed regions should be displaying again
…KE tests (#10593)

* Add assertions for lke tests

* update comments

* Added changeset: Add assertions for created LKE cluster in Cypress LKE tests

* update after reviews
…elete tests (#10612)

* combine vpc details page subset create, edit, and delete tests

* Added changeset: Combine VPC details page subnet create, edit, and delete Cypress tests
Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
)

* debounce input value so less requests are made

* add unit test

* changeset and improve test name

* add a default debounce of `500` ms

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
… delete (#10542)

* M3-7957 Cypress integration test for SSH key update and delete

* Fixed comments

* Added changeset: Cypress integration test for SSH key update and delete
…node data is being loaded or there is a form error (#10618)
bnussman-akamai and others added 10 commits July 2, 2024 13:36
…de Create v2 (#10623)

* add cluster pricing to summary

* Added changeset: Add Marketplace Cluster pricing support to Linode Create v2

* clean up and make more robust

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ng Cypress tests (#10633)

* Place Linodes created by Cypress tests behind VLAN, increase Clone timeout

* Add changeset
* Allow passing SX on PlanPanel

* missed db resize

* revert initial changes and remove paper border in dark mode
* remove region helper text

* Added changeset: Region helper text on the Image Upload page

* remove extra prop

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* save progress

* save progress

* save progress

* begin adding unit testing

* add more unit testing

* update how image is passed via props

* add test and adjust regions filter

* dial in

* more testing

* add cypress test

* fix spelling

* Added changeset: Add Manage Image Regions Drawer

* update cypress jsdoc

* Added changeset: Update `updateImageRegions` to accept `UpdateImageRegionsPayload` instead of `regions: string[]`

* add `Readonly` utility type to `IMAGE_REGION_STATUS_TO_STATUS_ICON_STATUS`

* rearchitecture so that `useEffect` is not needed

* update unit tests

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
)

* initial commit: save progress

* update with dynamic flag data

* Added changeset: Design update dismissible banner
…inode Create (#10636)

* add notice to both create flows with unit tests

* fix import

* fix error prop

* Added changeset: Add Image distributed compatibility notice to Linode Create

* Apply suggestions from code review

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* update tooltip to say `distributed compute regions` insted of `distributed regions`

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
* token updates: Fix chip bg/color

* token updates: Fix chip bg/color
Release v1.123.0 - `release` → `staging`
@dwiley-akamai dwiley-akamai added the Release Cloud Manager releases label Jul 8, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jul 8, 2024
@dwiley-akamai dwiley-akamai requested review from a team as code owners July 8, 2024 18:38
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning ad changesets all seem in order - looking good! 🚢

Copy link

cypress bot commented Jul 8, 2024

3 flaky tests on run #6228 ↗︎

0 395 2 0 Flakiness 3

Details:

Merge pull request #10648 from linode/release-v1.123.0
Project: Cloud Manager E2E Commit: d92c2a572b
Status: Passed Duration: 22:07 💡
Started: Jul 8, 2024 6:37 PM Ended: Jul 8, 2024 6:59 PM
Flakiness  stackscripts/create-stackscripts.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Create stackscripts > creates a StackScript with Any/All target image Screenshots Video
Flakiness  linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  parentChild/account-switching.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page Screenshots Video

Review all test suite changes for PR #10652 ↗︎

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging looked good to me. 🚀 We appear to have 3 flaky tests, but no CI failures.

We'll want to turn the design token banner on prod too, upon release.

Copy link

github-actions bot commented Jul 8, 2024

Coverage Report:
Base Coverage: 83.12%
Current Coverage: 82.23%

@dwiley-akamai dwiley-akamai merged commit 574743f into master Jul 8, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Cloud Manager releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.