fix: [M3-8303] - Remove Paper border in dark theme #10638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
commented
Jul 2, 2024
packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx
Outdated
Show resolved
Hide resolved
abailly-akamai
requested review from
jdamore-linode and
cpathipa
and removed request for
a team
mjac0bs
reviewed
Jul 2, 2024
There was a problem hiding this comment.
The places that you called out in the PR looked good in both dark and light modes.
I found one more place that the plans table is showing a border, and a handful of places this is happening in other components with papers.
Kube Details > Add a Node Pool
Linode Migrate
Rescue Linode
Rebuild Linode
Linode Details > Storage > select an existing disk or add one > Clone:
|
@mjac0bs ouch thanks for point this out. This isn't the right fix then. Going to revise this |
abailly-akamai
changed the title
|
@mjac0bs alright!
Not as nice without the borders, but the amount of regressions this introduced is enough to justify revisiting at a later point - CC @jaalah-akamai |
mjac0bs
approved these changes
Jul 2, 2024
|
Coverage Report: ✅ |
cpathipa
approved these changes
Jul 2, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Jul 3, 2024
* Allow passing SX on PlanPanel * missed db resize * revert initial changes and remove paper border in dark mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
A regression was introduced in the tokens update that added a border to the paper. Was looking kinda nice and matching CDS (which i assume was the intent, added border in may unwanted places where a Paper is sitting in another container. The short resolution is to remove the border all together (which matches the light theme) and revisit as needed when the time comes. Since the paper has a background, there is still enough discerning between the Paper and the page.
ℹ️ This is a regression from the theme update, therefore not in production (no need for a changeset)
Changes 🔄
Target release date 🗓️
7/8 2024
Preview 📷
How to test 🧪
Paths to test (Dark Mode Only)
(see other screenshots added by @mjac0bs in the comments)
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply