-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8066] - Debounce the Linode Create v2 VLANSelect
#10628
Merged
bnussman-akamai
merged 4 commits into
linode:develop
from
bnussman-akamai:M3-8066-debounce-vlan-select
Jul 2, 2024
Merged
upcoming: [M3-8066] - Debounce the Linode Create v2 VLANSelect
#10628
bnussman-akamai
merged 4 commits into
linode:develop
from
bnussman-akamai:M3-8066-debounce-vlan-select
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
hana-akamai and
AzureLatte
and removed request for
a team
July 1, 2024 15:06
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Jul 1, 2024
AzureLatte
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
bnussman-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jul 2, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Jul 3, 2024
…ode#10628) * debounce input value so less requests are made * add unit test * changeset and improve test name * add a default debounce of `500` ms --------- Co-authored-by: Banks Nussman <banks@nussman.us>
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
VLANSelect
created for and used on Linode Create v2 ⏲️useDebouncedValue
hook to make this easyPreview 📷
Screen.Recording.2024-07-01.at.11.04.13.AM.mov
Screen.Recording.2024-07-01.at.11.03.21.AM.mov
How to test 🧪
Prerequisites
Linode Create v2
Verification steps
VLANSelect
is debounced and works as expectedAs an Author I have considered 🤔