upcoming: [M3-8282] - Prevent Linode Create v2 from toggling mid-creation #10611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
jdamore-linode and
jaalah-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
force-pushed
the
M3-8282-prevent-linode-create-flow-toggling-mid-creation
branch
from
ce2cf30
to
572b952
Compare
abailly-akamai
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Good idea - now, this also means that when we want to turn off LinodeCreateV2 if we have a bug for instance, more users could encounter it (and report it) while carrying on with the erroneous flow till they restart it. Probably not a huge concern considering we don't anticipate such scenario, this current approach is still improving a much more likely case. Just wanted to point it out in case there's a 100% proof way to handle this.
jaalah-akamai
approved these changes
Jul 1, 2024
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Jul 3, 2024
…tion (linode#10611) * hold flag value in state so it does not change * Added changeset: Prevent Linode Create v2 from toggling mid-creation --------- Co-authored-by: Banks Nussman <banks@nussman.us>
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Screen.Recording.2024-06-25.at.12.13.54.PM.mov
Screen.Recording.2024-06-25.at.12.13.09.PM.mov
How to test 🧪
As an Author I have considered 🤔