upcoming: [DI-19062] - Dashboard Select component in cloudpulse global filters view #10589
Conversation
nikhagra-akamai
requested review from
bnussman-akamai and
carrillo-erik
and removed request for
a team
| setURL( | ||
| `http://blr-lhv95n.bangalore.corp.akamai.com:9000/v4/monitor/services/linode/dashboards` | ||
| ), | ||
| setMethod('GET'), | ||
| setHeaders({ | ||
| Authorization: 'Bearer vagrant', |
There was a problem hiding this comment.
Is this URL and credential a placeholder? I'm not sure this should be shipped
There was a problem hiding this comment.
changed the url & creds
| @@ -0,0 +1,2 @@ | |||
| export * from './types' | |||
| export * from './dashboards' | |||
There was a problem hiding this comment.
Nit: could you and your team use editors that support editorconfig? Files should end in a newline and editorconfig will ensure this is the case. In the meantime, the newlines should be added/restored
| ), | ||
| setMethod('GET'), | ||
| setHeaders({ | ||
| Authorization: '', //Authorization will be updated once the end-point is ready, till then will use mock data |
There was a problem hiding this comment.
If this is using API-v4 we should probably just remove this because Cloud Manager will handle setting the auth token
There was a problem hiding this comment.
See also: https://linode.github.io/manager/development-guide/14-configuring-environments.html this will probably help a lot to ease the burden of switching between API environments during feature development
There was a problem hiding this comment.
Optional: It might be nice to have jsdoc comments describing the fields
|
Coverage Report: ✅ |
|
Nice job! Please include a |
Description 📝
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>Commit Types:
feat: New feature for the user (not a part of the code, or ci, ...).fix: Bugfix for the user (not a fix to build something, ...).change: Modifying an existing visual UI instance. Such as a component or a feature.refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test: New tests or changes to existing tests. Does not change the production code.upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history