test: [M3-7320] - De-Parameterize Cypress Domain Record Create Tests #10615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrillo-erik
added
the
e2e
carrillo-erik
requested review from
jaalah-akamai,
AzureLatte and
jdamore-linode
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
changed the title
mjac0bs
approved these changes
Jun 27, 2024
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/domains/smoke-create-domain-records.spec.ts
Outdated
Show resolved
Hide resolved
jdamore-linode
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks @carrillo-erik! Especially appreciate the clean-up: replacing the deprecated helpers, improving const names, etc.
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The domain record tests in
smoke-create-domain-records.spec.tsare parameterized against an array containing 5 items (each item representing a domain record type that can be created). This PR combines the tests into a single test which attempts to create each type of record as a result. By reducing the number of tests from 5 to 1, it results in a more performant solution (cuts test run time in half).Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
2024/07/08
Preview 📷
How to test 🧪
Verification steps
yarn cy:debugthen run thesmoke-create-domain-records.spec.tstest in the browser.yarn cy:run -s "cypress/e2e/core/domains/smoke-create-domain-records.spec.ts"As an Author I have considered 🤔
Check all that apply