-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update Object Storage tests to mock account capabilities
as needed
#10602
test: Update Object Storage tests to mock account capabilities
as needed
#10602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this fix out so quick 🛠️
Approved since these are now passing for me locally 🎉 but we should wait until CI passes -- also should we add a changeset?
I didn't add one because I think @cpathipa is going to merge this into the release branch. Not sure if adding one would throw things off |
Coverage Report: ✅ |
Let's make a ticket to add a version of this test with multi-cluster enabled (same for other tests). |
…ties as needed for multi cluster
…eeded (#10602) * mock account capabilities as needed * Added changeset: Update Object Storage tests to mock account capabilities as needed for multi cluster --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Description 📝
capabilities
as needed 👤Object Storage Access Key Regions
capability and many of our tests were written under the assumption thatObject Storage Access Key Regions
was not returned incapabilities
How to test 🧪
As an Author I have considered 🤔