test: [M3-6620] - Add assertions for created LKE cluster in Cypress LKE tests #10593
Conversation
AzureLatte
requested review from
dwiley-akamai and
cpathipa
and removed request for
a team
|
Coverage Report: ✅ |
| let totalcpu = 0; | ||
| let totalmemory = 0; | ||
| let totalstorage = 0; | ||
| let monthprice = 0; |
There was a problem hiding this comment.
Let's camel case these to be consistent with how we typically handle variable names
There was a problem hiding this comment.
Nice catch! I will update them
| if (clusterPlan.size == 2 && clusterPlan.type == 'Linode') { | ||
| totalcpu = totalcpu + nodeCount * 1; | ||
| totalmemory = totalmemory + nodeCount * 2; | ||
| totalstorage = totalstorage + nodeCount * 50; | ||
| monthprice = monthprice + nodeCount * 12; | ||
| } | ||
| if (clusterPlan.size == 4 && clusterPlan.type == 'Linode') { | ||
| totalcpu = totalcpu + nodeCount * 2; | ||
| totalmemory = totalmemory + nodeCount * 4; | ||
| totalstorage = totalstorage + nodeCount * 80; | ||
| monthprice = monthprice + nodeCount * 24; | ||
| } | ||
| if (clusterPlan.size == 4 && clusterPlan.type == 'Dedicated') { | ||
| totalcpu = totalcpu + nodeCount * 2; | ||
| totalmemory = totalmemory + nodeCount * 4; | ||
| totalstorage = totalstorage + nodeCount * 80; | ||
| monthprice = monthprice + nodeCount * 36; | ||
| } |
There was a problem hiding this comment.
On first glance I found these a bit unclear. The four variables are initialized to 0 and don't get modified anywhere else, right? Couldn't we just do, for example, totalStorage = nodeCount * 50?
There was a problem hiding this comment.
This is for the scenario when different linodes selected, the values can be calculated as a total. For example, when both clusterPlan.size == 2 && clusterPlan.type == 'Linode' and clusterPlan.size == 4 && clusterPlan.type == 'Dedicated' picked, the four variables need to be added based on the previous sum.
mjac0bs
added
Approved
…KE tests (linode#10593) * Add assertions for lke tests * update comments * Added changeset: Add assertions for created LKE cluster in Cypress LKE tests * update after reviews
Description 📝
Assertions should be added to the LKE creation e2e test to confirm that the correct information is shown
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply