fix: Distributed regions not displaying in the Linode Create flow #10631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hana-akamai
added
Gecko Beta
hana-akamai
requested review from
jaalah-akamai and
abailly-akamai
and removed request for
a team
|
I don't think this PR needs a changeset since the regression hasn't hit production yet |
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Fix makes sense to me, but I wonder if we should fix the typescript type of getQueryParamsFromQueryString and the casts of params.type as LinodeCreateType because they seems to be the root of the issue.
Linode Create v2 has a more typesafe way to handle query params, but it might still be worth improving upon in Linode Create v1
|
@bnussman-akamai Agreed, M3-8285 will address that |
|
@hana-linode are you sure these are the only tags needed? I have those in my dev account and distributed regions are not showing up in alpha at all. |
abailly-akamai
approved these changes
Jul 2, 2024
hana-akamai
added
Approved
nikhagra-akamai
pushed a commit
to nikhagra-akamai/manager
that referenced
this pull request
Jul 3, 2024
…10631) ## Description 📝 Looks like there was a change made to the `isDistributedRegionSupported` function which caused a regression in the distributed regions displaying in the Linode Create flow ## How to test 🧪 ### Prerequisites (How to setup test environment) - Ensure your account has the `new-dc-testing`, `edge_testing` and `edge_compute` customer tags ### Reproduction steps (How to reproduce the issue, if applicable) - Go to the remote dev environment and observe no Distributed regions in the Linode Create flow ### Verification steps (How to verify changes) - Either locally or in the preview link, go to the Linode Create flow. Distributed regions should be displaying again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Looks like there was a change made to the
isDistributedRegionSupportedfunction which caused a regression in the distributed regions displaying in the Linode Create flowPreview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
new-dc-testing,edge_testingandedge_computecustomer tagsReproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply