Release v1.123.0 fixes #10650
Merged
Release v1.123.0 fixes #10650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Jul 8, 2024
| @@ -555,10 +555,10 @@ export const lightTheme: ThemeOptions = { | |||
| styleOverrides: { | |||
| clickable: { | |||
| '&:focus': { | |||
| bbackgroundColor: Color.Brand[40], // TODO: This was the closest color according to our palette | |||
There was a problem hiding this comment.
seems like this typo was one of the culprit for the dark theme no inheriting bg colors
abailly-akamai
requested review from
jdamore-linode,
bnussman-akamai and
jaalah-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Jul 8, 2024
jaalah-akamai
approved these changes
Jul 8, 2024
abailly-akamai
merged commit 719841b
into
linode:release-v1.123.0
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix an issue with the clickable Chip not being readable in Dark Theme.
Seems like more could be done to improve those in next iterations, but meanwhile we're only fixing readability here
Changes 🔄
ℹ️ No need for a changeset, this bug has not reached production yet
Target release date 🗓️
7/8/2024
Preview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply