Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version string to brave_installer.exe #580

Closed
simonhong opened this issue Jul 18, 2018 · 3 comments · Fixed by brave/brave-core#722
Closed

Add version string to brave_installer.exe #580

simonhong opened this issue Jul 18, 2018 · 3 comments · Fixed by brave/brave-core#722

Comments

@simonhong
Copy link
Member

It would be good to add version to installer executable name like brave_intaller_67_0_50_11.exe

@bbondy bbondy added this to the Backlog milestone Jul 26, 2018
@simonhong simonhong self-assigned this Oct 23, 2018
@simonhong simonhong modified the milestones: 1.x Backlog, 0.56.x - Release Nov 8, 2018
@LaurenWags
Copy link
Member

@simonhong does this need manual QA? if so, can you provide a test plan?

@simonhong
Copy link
Member Author

@LaurenWags Oops! I forgot to tag. This doesn't need manual QA.

@LaurenWags
Copy link
Member

great, thanks @simonhong 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants