Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add province-level targeting for Canada + US-Wyoming #16682

Closed
iambrianfung opened this issue Jun 29, 2021 · 4 comments · Fixed by brave/brave-core#15009
Closed

Add province-level targeting for Canada + US-Wyoming #16682

iambrianfung opened this issue Jun 29, 2021 · 4 comments · Fixed by brave/brave-core#15009
Assignees

Comments

@iambrianfung
Copy link
Collaborator

iambrianfung commented Jun 29, 2021

Description

Add province-level targeting for Canadian Provinces

Include
['CA-AB', 'Alberta'],
['CA-BC', 'British Columbia'],
['CA-MB', 'Manitoba'],
['CA-NB', 'New Brunswick'],
['CA-NS', 'Nova Scotia'],
['CA-ON', 'Ontario'],
['CA-QC', 'Quebec'],
['CA-SK', 'Saskatchewan']

Exclude the following provinces
'CA-NL', 'Newfoundland & Labrador'
'CA-PE', 'Prince Edward Island'
'CA-NT', 'Northwest Territories'
'CA-YT', 'Yukon'
'CA-NU', 'Nunavut'

iOS does not show the UI at this time; however, we should raise a separate issue for iOS just in case the functionality is re-enabled in the future

@iambrianfung iambrianfung added feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 29, 2021
@iambrianfung
Copy link
Collaborator Author

We have also been approved to include US-WY (Wyoming) as well.

@iambrianfung iambrianfung changed the title Add province-level targeting for Canada Add province-level targeting for Canada + US-Wyoming Jul 12, 2021
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude QA/Yes labels Jul 26, 2021
@tmancey tmancey added OS/iOS Fixes related to iOS browser functionality and removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Oct 26, 2021
@tmancey tmancey added OS/iOS Fixes related to iOS browser functionality and removed OS/iOS Fixes related to iOS browser functionality labels Feb 15, 2022
@tmancey
Copy link
Contributor

tmancey commented Aug 12, 2022

@iambrianfung US-WY is already part of the ads library. Removing from description. Thanks

@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/include and removed OS/iOS Fixes related to iOS browser functionality labels Aug 12, 2022
@btlechowski
Copy link

btlechowski commented Oct 11, 2022

Verification passed on

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#15009

Case 1

US-CA
{"country":"US","region":"CA"}
brave://rewards
image
brave://settings/rewards
image

CA-QC
{"country":"CA","region":"QC"}
brave://rewards
image
brave://settings/rewards
image

Verified fetching of ads subdivision target was scheduled debug=false

[12874:12874:1011/180007.425878:VERBOSE1:subdivision_targeting.cc(224)] Successfully fetched subdivision target
[12874:12874:1011/180007.431500:VERBOSE1:subdivision_targeting.cc(286)] Fetch ads subdivision target in 3 hours, 35 minutes, 24 seconds at 21:35:31.279

Verified fetching of ads subdivision target was scheduled debug=true

[14148:14148:1011/180957.820504:VERBOSE1:subdivision_targeting.cc(224)] Successfully fetched subdivision target
[14148:14148:1011/180957.821417:VERBOSE1:subdivision_targeting.cc(286)] Fetch ads subdivision target in 0 hours, 3 minutes, 54 seconds at 18:13:51.748

Verified ads subdivision target is fetched when scheduled

[14148:14148:1011/181351.751012:VERBOSE1:subdivision_targeting.cc(199)] FetchSubdivisionTargeting
[14148:14148:1011/181351.751208:VERBOSE2:subdivision_targeting.cc(200)] GET /v1/getstate
[14148:14148:1011/181351.751416:VERBOSE6:subdivision_targeting.cc(204)] URL Request:
  URL: https://geo.ads.brave.com/v1/getstate
  Method: kGet
[14148:14148:1011/181351.967405:VERBOSE1:subdivision_targeting.cc(213)] OnFetchSubdivisionTargeting
[14148:14148:1011/181351.967830:VERBOSE6:subdivision_targeting.cc(215)] URL Response:
  URL: https://geo.ads.brave.com/v1/getstate
  Response Status Code: 200

Case 2

US-CA
{"country":"US","region":"CA"}
brave://rewards
image
brave://settings/rewards
image

CA-QC
{"country":"CA","region":"QC"}
brave://rewards
image
brave://settings/rewards
image

Change Regional ad relevance to Manitoba
image
image

Case 3

CA-QC
{"country":"CA","region":"QC"}
brave://rewards
image
brave://settings/rewards
image

Changed locale to Manitoba
image

Run brave in Polish locale (PL)
image
image

ad relevance is available CA-QC
{"country":"CA","region":"QC"}
image
image

Case 4

Verified `United States-Oregon` ad is served for `United States-Oregon` ``` [22903:22903:1021/122619.839189:VERBOSE1:eligible_notification_ads_v1.cc(191)] 2 eligible ads out of 2 ads for untargeted segment [22903:22903:1021/122619.839300:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad [22903:22903:1021/122619.839695:VERBOSE1:notification_ad_serving.cc(125)] Found 2 eligible ads [22903:22903:1021/122619.839821:VERBOSE1:notification_ad_serving.cc(193)] Served notification ad: placementId: 8cf8f8ed-47ac-4e7f-82db-be4b3d78900d creativeInstanceId: d402c3dd-416f-4f47-952a-fa2429d4d951 creativeSetId: 0d0aade3-3a1f-4a64-bd99-a12e65fea771 campaignId: b9e77868-b83b-4c48-8631-9dbd0737c153 advertiserId: 2318807a-a4bb-4b81-bbc8-abd71af01800 segment: untargeted title: United States-Oregon body: United States-Oregon targetUrl: https://odos.xyz/ ```

Case 5

Verified `Canada-Quebec` ad is served for `Canada-Quebec` ``` [26471:26471:1021/133101.547807:VERBOSE1:eligible_notification_ads_v1.cc(191)] 1 eligible ads out of 2 ads for untargeted segment [26471:26471:1021/133101.548364:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad [26471:26471:1021/133101.549383:VERBOSE1:notification_ad_serving.cc(125)] Found 1 eligible ads [26471:26471:1021/133101.549914:VERBOSE1:notification_ad_serving.cc(193)] Served notification ad: placementId: 740325f9-fb76-422b-8ae4-c2593ee7e119 creativeInstanceId: d402c3dd-416f-4f47-952a-fa2429d4d951 creativeSetId: 0d0aade3-3a1f-4a64-bd99-a12e65fea771 campaignId: b9e77868-b83b-4c48-8631-9dbd0737c153 advertiserId: 2318807a-a4bb-4b81-bbc8-abd71af01800 segment: untargeted title: Canada-Quebec body: Canada-Quebec targetUrl: https://odos.xyz/

</details>

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 20, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 20, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016

Used Test Plan in brave/brave-core#15009 (comment) as reference

Case 1 - PASS

US-CA CA-QC
screenshot-1666297054981 screenshot-1666298158150
Screen Shot 2022-10-20 at 4 17 12 PM Screen Shot 2022-10-20 at 4 35 45 PM

Case 2 - PASS

US-CA
{"country":"US","region":"CA"}
brave://rewards
0

CA-QC
{"country":"CA","region":"QC"}
brave://rewards
0

Change Regional ad relevance to Manitoba
0

Case 3 - PASS

CA-QC
{"country":"CA","region":"QC"}
brave://rewards
0

Changed locale to Manitoba
0

Run brave in Polish locale (PL)
0

ad relevance is available CA-QC
{"country":"CA","region":"QC"}
0

Case 4 - PASS

  • Verified included Canadian provinces
0

Case 5 - PASS

  • Verified included US-WY region
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants