Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional ad relevance is not shown in brave://rewards after changing locale #24342

Closed
btlechowski opened this issue Jul 29, 2022 · 4 comments
Closed
Assignees
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

Follow up to #21038. The issue is still reproducible.

Steps to Reproduce

  1. Set locale to English (United States). On Windows: Set Regional format Windows setting to English (United States)
  2. Use US connection (or use charles to override https://geo.ads.brave.com/v1/getstate with {"country":"US","region":"CA"})
  3. Run Brave with logging enabled
  4. Enable rewards and ads
  5. Make sure that response from https://geo.ads.brave.com/v1/getstate has proper country(US) and region
  6. Open Brave Private Ads settings in brave://rewards/
  7. Check if Regional ad relevance is shown
  8. Change Regional ad relevance to Alabama
  9. Close Brave
  10. Set locale to Poland Polish
  11. Run Brave
  12. Open Brave Private Ads settings in brave://rewards/
  13. Close Brave
  14. Set locale to English (United States)
  15. Run Brave
  16. Open Brave Private Ads settings in brave://rewards/

Actual result:

Regional ad relevance is not shown
image

Expected result:

Regional ad relevance is shown
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.42.83 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Ubuntu 18.04 LTS

cc @rebron @tmancey @aseren @brave/qa-team

@btlechowski btlechowski added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude QA/Test-Plan-Specified feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jul 29, 2022
@tmancey tmancey added bug and removed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Aug 3, 2022
@tmancey
Copy link
Contributor

tmancey commented Sep 8, 2022

@aseren if you could close and add a QA/Yes label and set the milestone when merging #16682 that would be great :-)

@aseren aseren added the QA/Yes label Sep 9, 2022
@aseren aseren added this to the 1.45.x - Nightly milestone Sep 9, 2022
@aseren
Copy link

aseren commented Sep 9, 2022

The issue was fixed here: #16682

@btlechowski
Copy link
Author

Verification passed on

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

Default: California
image

Changed to Alabama
image

After switching from PL to US, Alabama is shown
image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 19, 2022

Verification PASSED on Samsung galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.106

  • Confirmed that when country and region is overriden to {"country":"US","region":"CA"}) the Regional ad relevance is shown in the brave://rewards Ads settings section
  • Confirmed that when the locale is set to Poland Polish the Regional ad relevance is NOT shown in the brave://rewards Ads settings section (Regional ad relevance is supported for only "US")
Step 2 Step 7 Step 8 Step 10 Step 12 Step 16
image (8) Screenshot_20221019-224358_Brave Screenshot_20221019-224505_Brave Screenshot_20221019-224638_Settings Screenshot_20221019-224707_Brave Screenshot_20221019-224819_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Archived in project
Development

No branches or pull requests

4 participants