Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text embedding processing for ad matching MVP #23424

Closed
moritzhaller opened this issue Jun 13, 2022 · 3 comments · Fixed by brave/brave-core#14393
Closed

Implement text embedding processing for ad matching MVP #23424

moritzhaller opened this issue Jun 13, 2022 · 3 comments · Fixed by brave/brave-core#14393

Comments

@moritzhaller
Copy link

No description provided.

@moritzhaller moritzhaller changed the title Add ad targeting V2 POC Implement word embedding based ad matching MVP Jun 13, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 21, 2022
@LorenzoMinto LorenzoMinto changed the title Implement word embedding based ad matching MVP Implement word embedding processing for ad matching MVP Jul 29, 2022
@moritzhaller moritzhaller changed the title Implement word embedding processing for ad matching MVP Implement text embedding processing for ad matching MVP Aug 1, 2022
@kjozwiak kjozwiak reopened this Aug 30, 2022
@kjozwiak
Copy link
Member

Removing from the 1.43.x milestone as brave/brave-core#14393 is still opened and hasn't been merged into master yet. We're releasing 1.43.x this week so there's no way this is making it. We only move issues into milestones once they've actually landed in the target milestone and brave/brave-core#14393 is still opened.

@kjozwiak kjozwiak removed this from the 1.43.x - Release milestone Aug 30, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 19, 2022
@LaurenWags LaurenWags modified the milestone: 1.45.x - Beta Sep 28, 2022
@LaurenWags
Copy link
Member

@ptjames Adding QA/Blocked label as test plan mentions building locally which QA does not do, please provide additional test plan, can work with @btlechowski on this as needed.

@btlechowski
Copy link

Verification passed on

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#14393

Verified text embedding is working:

[5051:5051:1009/140553.354039:VERBOSE3:text_embedding_processor.cc(72)] Successfully logged text embedding HTML event
[5051:5051:1009/140553.373045:VERBOSE3:text_embedding_processor.cc(80)] Successfully purged stale text embedding HTML events

Verified embeddings being stored in table text_embedding_html_event
image

Verified embeddings are not duplicated for the same id:
Before page reload:
image
After page reload:
image

Verified when embedding is not possible, proper message is shown:

[6876:6876:1009/144455.972530:VERBOSE1:text_embedding_processor.cc(53)] No text available for embedding

Logged #25878 for failed embedding on wikipedia pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment