Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Refresh status" with refresh icon only #20195

Closed
Miyayes opened this issue Dec 21, 2021 · 3 comments · Fixed by brave/brave-core#14987
Closed

Replace "Refresh status" with refresh icon only #20195

Miyayes opened this issue Dec 21, 2021 · 3 comments · Fixed by brave/brave-core#14987

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 21, 2021

Description

"Refresh status" takes up too much horizontal space and can cause new lines, etc. depending on translations. Replace it with a refresh icon only so that it can be moved to the right of the "Verified creator" label.

Note: Ensure that there is enough spacing/margin between the "Verified creator" label and the refresh icon.

Solution

Use the following icon:
image

@Miyayes
Copy link
Collaborator Author

Miyayes commented Dec 21, 2021

@minkyeongshin do you have any preferred refresh icon?

@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Dec 22, 2021
@Miyayes Miyayes added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Dec 22, 2021
@Miyayes Miyayes added the QA/Yes label Jan 8, 2022
@Miyayes Miyayes removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Sep 2, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. and removed priority/P4 Planned work. We expect to get to it "soon". needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Sep 2, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 2, 2022

Icon received. Ready to go. @mkarolin

@stephendonner
Copy link

Verified PASSED using

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. installed 1.45.75
  2. launched Brave
  3. loaded jumde.github.io
  4. clicked on the BAT icon
  5. enabled Rewards
  6. clicked again on the BAT icon
  7. examined the new Refresh icon
example example
Screen Shot 2022-09-27 at 5 07 44 PM Screen Shot 2022-09-27 at 5 08 19 PM

Confirmed:

  • tooltip reads Refresh
  • clicking Refresh reloads via the following:

Url: https://pcdn.bravesoftware.com/publishers/prefixes/0d62
Result: Success
HTTP Code: 200
Body:
[13688:259:0927/171127.700040:VERBOSE9:logging_util.cc(135)]
[ RESPONSE HEADERS ]
Url: https://pcdn.bravesoftware.com/publishers/prefixes/0d62
Header accept-ranges: bytes
Header age: 24
Header cache-control: max-age=5259492
Header content-length: 1000
Header content-type: binary/octet-stream
Header date: Tue, 27 Sep 2022 21:11:04 GMT
Header etag: "6f278cc493b0591ed1826f7574f7bde6"
Header last-modified: Tue, 27 Sep 2022 19:00:12 GMT
Header server: AmazonS3
Header via: 1.1 fb7a91e6436d6c6ab7f46f75c256840c.cloudfront.net (CloudFront)
Header x-amz-cf-id: TU-mDEm0QKAzEvQtvVnA6Fhr2IpJ-uCiLR73jGGAoi-nWeWWVo86Qw==
Header x-amz-cf-pop: JFK51-C1
Header x-cache: Hit from cloudfront
[13688:259:0927/171127.700152:VERBOSE1:database_server_publisher_banner.cc(40)] Empty publisher banner data, skipping insert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants