Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave Ads rewards migration path #25384

Closed
tmancey opened this issue Sep 13, 2022 · 1 comment · Fixed by brave/brave-core#15091
Closed

Fix Brave Ads rewards migration path #25384

tmancey opened this issue Sep 13, 2022 · 1 comment · Fixed by brave/brave-core#15091
Assignees

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 13, 2022

Description

Brave Ads rewards migration path fails if ads_rewards, transaction_history or unblinded_payment_tokens nodes are missing from Default/confirmations.json when migrating

Steps to Reproduce

  1. If ads_rewards, transaction_history or unblinded_payment_tokens nodes are missing from Default/confirmations.json

Actual result:

Failed to initialize ads is shown in the verbose rewards logs.

Expected result:

Successfully initialized ads should be shown in the verbose rewards logs.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@btlechowski
Copy link

Verification passed on

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants