Two different servers can be set on two different profiles

[GeetaSarvadnya]

Description

Two different servers can be set on two different profiles

Steps to Reproduce

Pre-requisites: Enable sku and vpn flags via brave://flags and purchase a vpn

1. Clean profile 1.45.x
2. Follow the prerequisites
3. Enable VPN on profile 1
4. Create a profile 2 via hamburger menu
5. Ensure that VPN is connected in profile 2
6. Ensure that the same server is connected in profile 1 and profile 2
7. In profile 2, click on VPN and choose another server
8. Can't connect to server error is shown
9. Click on Try again button connects to selected server

Actual result:

Two different servers can be set on two different profiles

Expected result:

No sure, but I assume should not allow users to connect two different servers on two different profiles

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.45.78 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
Revision	3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	Windows 10 Version 21H2 (Build 19044.2006)

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @spylogsster @bsclifton

[GeetaSarvadnya]

While doing futher investigation on the issue found that IP points to the 2nd server on both the profiles although the different servers connected in the UI. Looks like UI bug?

[simonhong]

@GeetaSarvadnya Yes, it's UI issue. It's not updated properly when different server is used from another profile.

[kjozwiak]

The above requires 1.46.87 or higher for 1.46.x verification 👍 Believe we might need to wait to verify the above until we can QA the VPN feature with the new SKU SDK. @stephendonner @LaurenWags please correct me if I'm wrong.

[LaurenWags]

@kjozwiak correct afaik, have added QA/Blocked label until all server side/back end/website work is complete.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 10 Version 21H2 (Build 19044.2251)

• Verified the STR from the description and ensured below:
  • If we try to set the 2 two diffrent servers on two profiles (Profile 1 and Profile 2) the latest server will be set on both the profiles e.g: If we select CA profile 1 and before it gets connect to the server, if we try to select UK for profile 2, then server UK will be set on both the profiles
  • Confirmed ipleak.net points to same IP on both the profiles
  • Confirmed that same server name is shown for both the profiles

[stephendonner]

Verified PASSED using

Brave	1.46.122 Chromium: 108.0.5359.48 (Official Build) beta (x86_64)
Revision	18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS	macOS Version 11.7.1 (Build 20G918)

Steps:

1. installed 1.46.122
2. launched Brave
3. set up VPN with the default profile
4. created Profile 2 and switched to it
5. confirmed I was connected to the same default USA (West) server
6. switched to Japan
7. confirmed I was connected to a Japanese node
8. switched back to default profile/profile 1
9. confirmed I was connected to the same custom-selected Japan region's node

USA - West (profile 1)	USA - West (profile 2)

ipleak.net (profile 2)	ipleak.net (profile 1)