Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to sidebar bubble is only dismissed when clicked outside #21156

Closed
srirambv opened this issue Feb 17, 2022 · 7 comments · Fixed by brave/brave-core#14788
Closed

Add to sidebar bubble is only dismissed when clicked outside #21156

srirambv opened this issue Feb 17, 2022 · 7 comments · Fixed by brave/brave-core#14788
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.45.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Add to sidebar bubble is only dismissed when clicked outside

Steps to Reproduce

  1. Visit a page in a new tab
  2. Hover over the + icon in the sidebar
  3. Add to sidebar bubble is shown
  4. Move away from the +, bubble is not closed. Have to click outside to close it

Actual result:

Add.to.sidebar.mov

Expected result:

Should close the bubble if the mouse cursor moves away from the + button avoiding unnecessary clicks

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.53 Chromium: 98.0.4758.102 (Official Build) nightly (arm64)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes if flag enabled
  • Can you reproduce this issue with the beta channel? Yes if flag enabled
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @simonhong @rebron
@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Feb 17, 2022
@rebron
Copy link
Collaborator

rebron commented Feb 25, 2022

cc: @bradleyrichter

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Feb 25, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 14, 2022
@bradleyrichter
Copy link

@srirambv is correct since it should be hover-in, move-out. We could add a delay to the hover state and add a click state which would remain open until click-outside.

@simonhong
Copy link
Member

simonhong commented Mar 15, 2022 •
edited
Loading

IMO, giving more delays for showing when hovered would be better because button also interacts with click event.
Currently, sidebar item add bubble is shown very easily.
and I think clicking outside of bubble seems fine for dismissing

@simonhong
Copy link
Member

FYI, 200ms delay is given on hover to prevent launching item add bubble when user just bypass on the add button.

@bradleyrichter
Copy link

@simonhong 200ms delay sounds good. I assume the suer can also click on it immediately to open?

@simonhong
Copy link
Member

@bradleyrichter Yes, user can click to launch it to open immediatley.

@rebron rebron removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jul 5, 2022
@simonhong simonhong mentioned this issue Aug 24, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Aug 24, 2022
@simonhong
Updated sidebar add bubble hide logic
a4dbf3a 
fix brave/brave-browser#21156

Hide this bubble when user moves out from add button when this button
is launched by mouse hover. By hovering, user can't use bubble as
it'll be hidden quickly. That bubble acts like tooltip.
Instead, user should click the add button to use that bubble.
Bubble that launched by button click will get hidden
only when user clicks outside of bubble explicitely.
simonhong added a commit to brave/brave-core that referenced this issue Aug 30, 2022
@simonhong
Updated sidebar add bubble hide logic
d21cfff 
fix brave/brave-browser#21156

Hide this bubble when user moves out from add button when this button
is launched by mouse hover. By hovering, user can't use bubble as
it'll be hidden quickly. That bubble acts like tooltip.
Instead, user should click the add button to use that bubble.
Bubble that launched by button click will get hidden
only when user clicks outside of bubble explicitely.
@simonhong simonhong added this to the 1.45.x - Nightly milestone Aug 30, 2022
@stephendonner
Copy link

stephendonner commented Sep 27, 2022 •
edited
Loading

Verified PASSED using

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. installed 1.45.75
  2. launched browser
  3. loaded cnn.com
  4. hovered over the sidebar item + button
  5. waited
  6. confirmed tooltip reads Add to Sidebar (and confirmed no Sidebar "bubble" appeared)
  7. clicked on the + button
  8. confirmed I got the Add to Sidebar "bubble"
  9. clicked again on the + button to dismiss
  10. confirmed the Add to Sidebar "bubble" was dismissed
  11. clicked in various places outside the "bubble"
  12. confirmed the "bubble" was dismissed

Screencast

add-to-sidebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Updated sidebar add bubble hide logic brave/brave-core
5 participants
@stephendonner @rebron @simonhong @bradleyrichter @srirambv