Updated sidebar add bubble hide logic

fix brave/brave-browser#21156

Hide this bubble when user moves out from add button when this button
is launched by mouse hover. By hovering, user can't use bubble as
it'll be hidden quickly. That bubble acts like tooltip.
Instead, user should click the add button to use that bubble.
Bubble that launched by button click will get hidden
only when user clicks outside of bubble explicitely.

browser/ui/views/sidebar/sidebar_item_add_button.cc

@@ -38,6 +38,8 @@ void SidebarItemAddButton::OnButtonPressed() {
   if (timer_.IsRunning())
     timer_.Stop();
 
+  add_item_bubble_shown_by_click_ = true;
+
   DoShowBubble();
 }
 
@@ -50,6 +52,11 @@ void SidebarItemAddButton::OnMouseExited(const ui::MouseEvent& event) {
   SidebarButtonView::OnMouseExited(event);
   // Don't show bubble if user goes outo from add item quickly.
   timer_.Stop();
+
+  if (!add_item_bubble_shown_by_click_ && IsBubbleVisible()) {
+    DCHECK(add_item_bubble_widget_);
+    add_item_bubble_widget_->Close();
+  }
 }
 
 void SidebarItemAddButton::OnGestureEvent(ui::GestureEvent* event) {
@@ -71,13 +78,18 @@ void SidebarItemAddButton::AddedToWidget() {
 }
 
 void SidebarItemAddButton::OnWidgetDestroying(views::Widget* widget) {
+  DCHECK_EQ(add_item_bubble_widget_, widget);
+  add_item_bubble_widget_ = nullptr;
+  add_item_bubble_shown_by_click_ = false;
   observation_.Reset();
 }
 
 void SidebarItemAddButton::ShowBubbleWithDelay() {
   if (IsBubbleVisible())
     return;
 
+  DCHECK(!add_item_bubble_shown_by_click_);
+
   if (timer_.IsRunning())
     timer_.Stop();
 
@@ -87,10 +99,11 @@ void SidebarItemAddButton::ShowBubbleWithDelay() {
 }
 
 void SidebarItemAddButton::DoShowBubble() {
-  auto* bubble = views::BubbleDialogDelegateView::CreateBubble(
+  DCHECK(!add_item_bubble_widget_);
+  add_item_bubble_widget_ = views::BubbleDialogDelegateView::CreateBubble(
       new SidebarAddItemBubbleDelegateView(browser_, this));
-  observation_.Observe(bubble);
-  bubble->Show();
+  observation_.Observe(add_item_bubble_widget_);
+  add_item_bubble_widget_->Show();
 }
 
 bool SidebarItemAddButton::IsBubbleVisible() const {

browser/ui/views/sidebar/sidebar_item_add_button.h

@@ -48,6 +48,9 @@ class SidebarItemAddButton : public SidebarButtonView,
   void OnButtonPressed();
 
   raw_ptr<BraveBrowser> browser_ = nullptr;
+  raw_ptr<views::Widget> add_item_bubble_widget_ = nullptr;
+  // true when bubble is shown by add item button press. Otherwise, false.
+  bool add_item_bubble_shown_by_click_ = false;
   base::OneShotTimer timer_;
   base::CallbackListSubscription on_enabled_changed_subscription_;
   base::ScopedObservation<views::Widget, views::WidgetObserver> observation_{