Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to select a specific "Brave background" #25030

Closed
sangwoo108 opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#14867
Closed

Allow users to select a specific "Brave background" #25030

sangwoo108 opened this issue Aug 29, 2022 · 2 comments · Fixed by brave/brave-core#14867

Comments

@sangwoo108
Copy link

Subtask of #15252


  • When user select a specific brave background, that background should be applied for all NTPs
  • Sponsored image should be visible as is.
@stephendonner
Copy link

Verified PASSED using

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. installed 1.45.75
  2. launched Brave
  3. opened a new-tab page
  4. clicked on Customize
  5. clicked on Brave Backgrounds
  6. clicked on a background
  7. confirmed Refresh on every new tab was deselected automatically

Confirmed my chosen image was used for each new tab, excepting the Sponsored Images backgrounds.

example example example
Screen Shot 2022-09-27 at 10 38 12 AM Screen Shot 2022-09-27 at 10 38 20 AM Screen Shot 2022-09-27 at 10 40 15 AM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 30, 2022

Verification PASSED using

Brave | 1.45.80 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 21H2 (Build 22000.978)

Steps:

Case 1: Refresh on every new tab auto-deselected

  1. installed 1.45.80
  2. launched Brave
  3. opened a new-tab page
  4. clicked on Customize
  5. clicked on Brave Backgrounds
  6. clicked on a background
  7. confirmed Refresh on every new tab was deselected automatically

Confirmed chosen image was used for each new tab, excepting the Sponsored Images backgrounds.

step5 step6-7 result SI
image image image image

Case 2: Refresh on every new tab toggle ON

  1. continue from Case 1
  2. toggle ON Refresh on every new tab
  3. load new tabs
  4. Brave background images are rotated as expected
step 2 step3 step4
image image image

Verification passed on

Brave 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Ubuntu 18.04 LTS

Case 1: Refresh on every new tab auto-deselected

  1. installed 1.45.x
  2. launched Brave
  3. opened a new-tab page
  4. clicked on Customize
  5. clicked on Brave Backgrounds
  6. clicked on a background
  7. confirmed Refresh on every new tab was deselected automatically

Confirmed chosen image was used for each new tab, excepting the Sponsored Images backgrounds.

image
image
image
image

Case 2: Refresh on every new tab toggle ON

  1. continue from Case 1
  2. toggle ON Refresh on every new tab
  3. load new tabs
  4. Brave background images are rotated as expected

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants