One-time tip entries are temporarily not listed in brave://rewards

[stephendonner]

Description

One-time tip entries aren't listed in brave://rewards

Steps to Reproduce

1. install 1.46.24
2. launch Brave using Rewards/Ads staging
3. click on the BAT icon on the URL bar
4. click Start using Brave Rewards
5. dismiss the next dialog
6. click on Claim Tokens
7. solve the CAPTCHA
8. load https://laurenwags.github.io/
9. click on the BAT icon
10. click Send Tip
11. click Send Tip
12. open brave://rewards/
13. note One-Time Tips reads -5.00 BAT in mini ledger summary
14. scroll down to the Tips section above Monthly Tips
15. look for your tip 👓

Actual result:

No tip(s) shown

example 1	example 2

Expected result:

Tip(s) shown (listed out by recipient)

open brave://rewards-internals/ and note the tip

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.46.24 Chromium: 106.0.5249.65 (Official Build) nightly (x86_64)
Revision	3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	macOS Version 11.7 (Build 20G817)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

cc @LaurenWags @GeetaSarvadnya @kjozwiak @zenparsing @Miyayes

[zenparsing]

I was able to reproduce on a local build. It appears that when tip records are queried from the database we filter them based on the month of the local time, but the dates are stored in UTC. This can cause issues for dates like 9/30; the date is stored in the DB as UTC but filtered using local time.

[kjozwiak]

I was able to reproduce on a local build. It appears that when tip records are queried from the database we filter them based on the month of the local time, but the dates are stored in UTC. This can cause issues for dates like 9/30; the date is stored in the DB as UTC but filtered using local time.

Thanks @zenparsing. In that case, we can probably fix this whenever and remove as release/blocking. But I'll let the rewards team prioritise 👍 @LaurenWags @zenparsing @rebron please fee free to remove the release/blocking and prioritize as needed.

[GeetaSarvadnya]

It's working fine in all the channels for me. Is this macOS specific issue?

[LaurenWags]

cc @Miyayes for prioritization

[Miyayes]

I'm going to put a P2 on it, since this should probably be uplifted. That said, according to Kevin's investigation, it should only really rear its head at the end of the month (due to the different timezones), and isn't an across-the-board issue.

[kjozwiak]

So it looks like the Tip eventually does appear via brave://flags. Assuming it gets synced with sever-side and once the UTC/local time discrepancies gets resolved. Below is an example of the website that I tipped but didn't see it appear via brave:/flags due to the above. I checked a few hours ago and noticed it was now appearing/visible.