javafx replacement for file dialog #3005

Siedlerchr · 2017-07-13T09:53:06Z

The open functionality has been removed -> Directly possible in the entry editor
Contextmenu on maintable ->attach file now opens a file chooser dialog and afterwards this dialog for editing, e.g. adding a description

Only resizable to max screen size: (on my 24" with 1920x1200)

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef
Check documentation status (Issue created for outdated help page at help.jabref.org?)
If you changed the localization: Did you run gradle localizationUpdate?

* upstream/master: (30 commits) Add preference migration for keybdingings (#3007) Shutdown previus AutosaveManager and BackupManager during SaveAs (#2994) Run Checkstyle task after Test task (#3010) Mark LibraryOfCongressTest as a fetcher test (#3012) When browsing through the MainTable remember which EntryEditor tab was open (#3011) Improve performance of journal abbreviation loader (#3009) Update checkstyle 7.6.1 -> 8.0 Don't abort build when there are checkstyle violations (#3006) Reimplement content selectors (#3003) Only do a back up for bigger changes or if a different field is edited (#3004) Listen to change events for setting dirty status of database (#3001) Fix #2967: MathSciNet tab works again Fix #2902: Tab in entry editor moves to next text area Fix #2946: external changes are now correctly shown in the entry editor Fix #2998: improve auto completion (#3002) Fix mac keybinding by replacing ctrl it with meta key (#3000) Less backups (#2995) [WIP] Complete rework of the auto completion (#2965) Eclipse J Add switch indentation for Eclipse and add some new missing formatting options ...

* upstream/master: (41 commits) update xmlunit from 2.3.0 -> 2.4.0 update wiremock from 2.6.0 -> 2.7.0 update controlsfx from 8.40.12 -> 8.40.13 Fix group freeze by running markBasechange in swing thread (#3058) Localization: French: translation of new entries (#3050) Fix ads fetcher (#3048) Update translation (#3041) Translate new strings (#3040) Fix navigation in entry editor increases modifies font size (#3037) Initial idea for architectural decision records (#3033) Readd comment Readd comment Fix keybdining in entry editor in localized installation (#3030) Structuring Upgrade shadowJar Modernizer improvements Replace Reimplement MappedList.kt (#3032) Use https for the maven ej-technologies repo Upgrade modernizer plugin Remove separator next to search bar ...

* upstream/master: Add warning message if group with same name is already present (#3077) Fix #3062: Ctrl + F works again Fix del/copy/paste key trigger main table action in search bar (#3070) Fix markdown Update gradle from 4.0.1 to 4.0.2 Fix #3045 Update Transformer plugin Reimplement MappedList using a backigList (#3069) Fix importing preferences after resetting without restarting (#3065) Fix some spotbugs issues (#3060) Import dialog when fetch (#3025) Adapt CircleCI build Adapt CI script Closes #3027 and updates install4j to v7

open dialog with attach file action

* upstream/master: (188 commits) Show file description only if not empty Add file description to gui and fix sync bug (#3210) Don't highlight odd rows in file list editor (#3223) Fix assertion by removing typo (#3220) Update assertion to change of online reference (#3221) Put in null return Reformatted code, renamed method, added try/catch Add tests for removal changes Improve telemetry (#3218) Real test linking real other entry (#3214) Check for explicit group at different location Update java-string-similarity from 0.24 -> 1.0.0 Only remove ExplicitGroups from entries, but not keyword-based groups Localization: French: Translation of a new string (#3212) Fix null return Changed from Path to Optional<Path> Fix #2775: Hyphens in last names are properly parsed (#3209) Followup to Issue #3167 (#3202) Remove unused import in GroupTreeNode Move getEntriesInGroup to GroupTreeNode ...

Siedlerchr · 2017-09-23T18:48:39Z

src/main/java/org/jabref/gui/filelist/FileListDialogController.java

+            if (REMOTE_LINK_PATTERN.matcher(tfLink.getText()).matches()) {
+                Optional<ExternalFileType> type = ExternalFileTypes.getInstance().getExternalFileTypeByExt("html");
+                if (type.isPresent()) {
+                    cmbFileType.getSelectionModel().select(type.get());


@tobiasdiez
I would like to move this method and some others to the view Model, but I don't know how/or if I should expose the selection model of the combobox to the view model.

You have a few options here:

Create a property in the view model and bind the selected item property to it, similar to the following code:

jabref/src/main/java/org/jabref/gui/keyboard/KeyBindingsDialogController.java

Lines 37 to 41 in cbd6844

viewModel.selectedKeyBindingProperty().bind(

EasyBind.monadic(keyBindingsTable.selectionModelProperty())

.flatMap(SelectionModel::selectedItemProperty)

.selectProperty(TreeItem::valueProperty)

);

But I'm not sure if using a bidirectional binding works here out of the box, probably you need to use

jabref/src/main/java/org/jabref/gui/util/BindingsHelper.java

Line 75 in bee715d

public static <A, B> void bindBidirectional(Property<A> propertyA, Property<B> propertyB, Function<A, B> mapAtoB, Function<B, A> mapBtoA) {

or a similar helper method.

Just return the to-be-selected item from the method in the view model and then really select it here in the controller.

Option 1 is definitely the cleaner solution but maybe a bit harder to setup (but definitely worth the initial effort since a similar problem might appear in the future).

Siedlerchr · 2017-09-23T18:49:08Z

src/main/java/org/jabref/gui/filelist/FileListDialogController.java

+
+    private void setBindings() {
+
+        cmbFileType.itemsProperty().bindBidirectional(viewModel.externalFileTypeProperty());


@tobiasdiez Here the binding is created, a simple list property for the combobox

this looks good! (a one-directional binding should suffice I think since it looks like the itemsProperty is never changed directly.)

* upstream/master: (79 commits) Update richtext and flowless (#3386) Source tab: hide notification pane when code is correct again (#3387) Titles are optional at crossref (#3378) Update entry for every change in the source panel (#3366) Rework AutoSetFileLinks (#3368) revert wrongly commited changes Refactorings (#3370) Fix freezing when running cleanup file operations like rename (#3315) This additional style setting for IDEA (#3355) Fix checkstyle Add proper equals to content selector Source tab entry duplication (#3360) Use CITE_COMMENT not only for external latex editors but also for cop… (#3351) Updating with new translations (#3348) Upgrade error-prone (#3350) Jabref_pt_BR partially updated (#3349) Delete unused code Extract difference finder from gui to logic Used late initialization for context menus (#3340) Fix NPE when calling with bib file as cmd argument (#3343) ...

* upstream/master: Improve SyncLang.py (#3184) Config intellj code style to adhere to empty lines checkstyle rule (#3365) Don't list same look and feels more than once (#3393) progessdialog and result table are now shown correclty on copy files Export pdf/linked files (#3147) Added checking integrity dialog (#3388)

* upstream/master: (30 commits) Add Hint for checking master version (#3439) Replace LinkedFiles backslashes with forward slashes (#3403) fix isbn result from chimbori (#3442) Feature java version check again (#3428) Fix test for quoted lang messages (#3424) Update gradle from 4.3 to 4.3.1 Fix #3411: ordering of fields in customized entry types works again (#3422) Backport of syncLang to python2 (#3420) Remove Versioneye badge Fix some error prone warnings Fix for issue #2721 append to a field (#3395) Fix travis - hopefully Remove 3.x changelog (#3250) Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library Try to enable LGTM Update guava from 23.2 -> 23.3 (#3409) Update wiremock from 2.8.0 -> 2.10.1 Move groups field from others to general (#3407) Fix checkstyle issues to repair build Fix #3046: No longer allow duplicate fields in customized entry types (#3405) ...

koppor · 2017-11-22T09:41:27Z

Discussion @Siedlerchr with @tobiasdiez required.

* upstream/master: (234 commits) Fix checkstyle Fix tests Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ...

Siedlerchr · 2017-12-29T10:13:15Z

src/main/java/org/jabref/gui/filelist/AttachFileAction.java

                panel.getBibDatabaseContext());
        editor.setVisible(true, true);
+
        if (editor.okPressed()) {


@tobiasdiez How do I handle such cases in javafx? The check for a return value? Should I do a showAndWait?
My initial idea would be to pass the UndoManager to the javafx view model (state manager? or other injection)
There are some other clases in which a similar stuff is executed which seems to a bit more complicated, e.g. the
DownloadExternalFile class

Good question. I think the return value should be accessed per getters of the FileListDialogView (this seems to be the most flexible and easiest solution - you don't need to create "Dialog return value classes" for more complex scenarios). These getters in the view should ask the view model of the dialog about the values. You can get the controller with

jabref/src/main/java/org/jabref/gui/AbstractView.java

Line 45 in 1172ed4

private Optional<AbstractController> getController() {

(just change the visibility) and then the view model with

jabref/src/main/java/org/jabref/gui/AbstractController.java

Line 20 in 1172ed4

public T getViewModel() {

For parameter injection, have a look at CopyFilesDialogView.

* upstream/master: Remove dependency to jgoodies-looks (#3458) Add simple gui test (#3399) Library properties: no change but.. (issue #3562) (#3579) Initialize previe before MainPanel to prevent NPEs on delete Fixes #3584

* upstream/master: Refactor shared package into the architecture (#3523)

* upstream/master: Add oaDOI fulltext fetcher (#3581) Refactor export code to fix #3576 (#3578) Fix #3359: Automatically remove colon and apostrophe from key pattern (#3506)

…esDlg * upstream/maintable-beta: (35 commits) Load all field editors using ViewLoader Use JabRef icons in FXML Move icon stuff to new package gui.icon Load EntryEditor using new ViewLoader Improve tooltip tests Fix import thread problem Don't use null as parameter in DialogService Make it easier to create FXML dialogs (#3880) update slf4j from 1.8.0-beta1 -> 1.8.0-beta2 New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Greek) New translations Menu_en.properties (Greek) New translations JabRef_en.properties (Japanese) New translations JabRef_en.properties (German) New translations JabRef_en.properties (Dutch) New translations JabRef_en.properties (Danish) New translations JabRef_en.properties (Chinese Simplified) ... # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/gui/AbstractView.java # src/main/java/org/jabref/gui/desktop/JabRefDesktop.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java # src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java # src/main/java/org/jabref/gui/protectedterms/ProtectedTermsDialog.java

still some NPEs

Siedlerchr · 2018-03-24T16:15:13Z

@tobiasdiez I tried to convert the EditfileDialog to the new dialog structure from #3880 but I do still get an NPE on loading the dialog:

caused by: java.lang.NullPointerException
	at org.jabref.gui.filelist.LinkedFileEditDialogView.initialize(LinkedFileEditDialogView.java:55) ~[main/:?]

tobiasdiez · 2018-03-24T16:35:27Z

And what is null there? If line 54 runs without any problems, then the setup seems to be fine and the FXML nodes are injected. Maybe the description field is not defined in the fxml?

Siedlerchr · 2018-03-24T16:46:28Z

@tobiasdiez No, it fails directly in the initalize, The viewModel which gets initialized in the ctor is null.
When debugging it crashes directly after/when calling ViewLoader.view(this) .load()
Btw, I noticed the same problem also occurs with the CopyLinkedFilesDialogView (Tools->Copy LInked Files)

tobiasdiez · 2018-03-24T17:10:42Z

ok, this makes sense since the initialization method is called during ViewLoader.load and at this point the view model is not yet created. Just move the viewModel = ... line to the beginning of the initialization method and it should work.

Siedlerchr · 2018-03-24T18:38:17Z

Works now. I just additionally had to add a close/cancel button to the dialogPane, for the copyFiles because otherwise the dialog is not closeable: https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Dialog.html

tobiasdiez

Thanks for the hard work over so many years 🍡

The code looks in general very good. I have a few smaller remarks. And let me add one general comment: These code reformattings make it very very hard to review the PR. For example, some files appearntly only contain formatting changes, without any actual changes to the code. This is confusing. Does eclipse provide an option to reformat only code that is actually changed instead reformatting everything once you open the file (I guess this is what happenend).

tobiasdiez · 2018-03-25T09:50:03Z

CHANGELOG.md

@@ -41,8 +41,10 @@ The new default removes the linked file from the entry instead of deleting the f
 - Pressing <kbd>ESC</kbd> while searching will clear the search field and select the first entry, if available, in the table. [koppor#293](https://github.com/koppor/jabref/issues/293)
 - We changed the metadata reading and writing. DublinCore is now the only metadata format, JabRef supports. (https://github.com/JabRef/jabref/pull/3710)
 - We added another CLI functionality for reading and writing metadata to pdfs. (see https://github.com/JabRef/jabref/pull/3756 and see http://help.jabref.org/en/CommandLine)
+- We improved the layout of the Edit file layout and made it resizable. We also tweaked the workflow for attaching files from the contextmenu, see https://github.com/JabRef/jabref/pull/3005


None of the changes in maintable-beta is currently in the changelog. Thus, for consistency, I would say remove it for the moment and add it to the list in #3621.

tobiasdiez · 2018-03-25T09:51:44Z

src/main/java/org/jabref/gui/BasePanel.java

-                                Localization.lang("Cancel"),
-                                Localization.lang("Disable this confirmation dialog"),
-                                optOut -> Globals.prefs.putBoolean(JabRefPreferences.WARN_BEFORE_OVERWRITING_KEY, !optOut));
+                        boolean overwriteKeysPressed = dialogService.showConfirmationDialogWithOptOutAndWait(


Are the changes in this file once again one of the strange eclipse formatting rules?

tobiasdiez · 2018-03-25T09:57:23Z

src/main/java/org/jabref/gui/copyfiles/CopyFilesDialogView.java

@@ -28,11 +29,14 @@ public CopyFilesDialogView(BibDatabaseContext bibDatabaseContext, CopyFilesResul
        this.setTitle(Localization.lang("Result"));
        this.setResizable(true);

+        this.getDialogPane().getButtonTypes().addAll(ButtonType.CLOSE);


The original button was labeled OK and I think this makes more sense than Close. Moreover, the close method in this class can now be removed, right?

The problem was that with an only OK button I was not able to close the dialog neither via the X in the corner nor via the OK button. It needs to have at least a button with Type CANCEL_CLOSE
Read the last paragraph: https://docs.oracle.com/javase/8/javafx/api/javafx/scene/control/Dialog.html

The Problem was that the OK button was not at the Dialog Pane, but inside the content and therefore did not work

tobiasdiez · 2018-03-25T10:07:22Z

src/main/java/org/jabref/gui/filelist/LinkedFilesWrapper.java

+import org.jabref.model.entry.LinkedFile;
+
+/**
+ * Workaround to inject {@link LinkedFile} into javafx controller


This should no longer be necessary.

tobiasdiez · 2018-03-25T10:12:38Z

src/main/java/org/jabref/gui/filelist/AttachFileAction.java

+
+            LinkedFilesWrapper wrapper = new LinkedFilesWrapper();
+            wrapper.setLinkedFile(newLinkedFile);
+            LinkedFileEditDialogView dialog = new LinkedFileEditDialogView(wrapper);


Do we really want to show the linked file editor dialog here? In my experience, I just click "OK" anyway and would expect that this is the case for most users (recall how long it took until somebody complained that the description was not shown in the file list). At least, I would add a preferences that controls the appearance of the dialog.

Previously there wasn't event he FileChooser shown .Instead it only showed the LinkedFilesEditor in which I then had to click open

Ok, then was the previous behavior even worse. What advantage do you see in displaying the dialog every time?

You can add a description and or choose a different file.

If you really think that the majority of users wants to add a description, then keep the current behavior....

tobiasdiez · 2018-03-25T10:34:24Z

src/main/java/org/jabref/preferences/PreferencesService.java

+
+    FileDirectoryPreferences getFileDirectoryPreferences();
+
+    String get(String key);


Please don't add generic methods like this! The idea was that the PreferencesService provides a typed interface for the preferences. Thus here it would be set/getWorkingDirectory with nio.path as argument/return value.

tobiasdiez · 2018-03-25T10:34:56Z

src/main/resources/org/jabref/gui/filelist/LinkedFileEditDialog.fxml

@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?>


Please add this file in the java folder and not resource

tobiasdiez · 2018-03-25T10:35:16Z

src/main/resources/org/jabref/gui/filelist/LinkedFileEditDialog.fxml

+            </Label>
+         </children>
+      </GridPane>
+   </content>


You can also add buttontypes here in the FXML file.

tobiasdiez · 2018-03-25T10:36:21Z

src/main/resources/org/jabref/gui/filelist/LinkedFileEditDialog.fxml

+        </rowConstraints>
+         <children>
+               <Label minWidth="95.0" text="%Link">
+                   <padding>


padding and layout stuff should be controlled using css and not in the fxml file.

tobiasdiez · 2018-03-25T10:36:46Z

src/main/resources/org/jabref/gui/filelist/LinkedFileEditDialog.fxml

+      <GridPane>
+        <columnConstraints>
+          <ColumnConstraints hgrow="NEVER" minWidth="10.0" prefWidth="100.0" />
+          <ColumnConstraints hgrow="ALWAYS" maxWidth="1.7976931348623157E308" minWidth="10.0" prefWidth="200.0" />


maxWidth = infinity ?

Siedlerchr · 2018-03-25T11:11:12Z

src/main/java/org/jabref/gui/filelist/LinkedFilesEditDialogViewModel.java

-        .withInitialDirectory(workingDir)
-        .withInitialFileName(fileName)
-        .build();
+                                                                                               .withInitialDirectory(workingDir)


@tobiasdiez this is how the indentation at column level works: As I said before it's not possible to align it at the dot position. So when I use indencation on column all things are then wrapped after Builder (Github doesn't show it that wide).

move fxml to java package remove wrapper class pass externalFileType to viewModel renammings

Add ok button to dialog pane

tobiasdiez · 2018-03-25T13:32:36Z

src/main/java/org/jabref/gui/filelist/LinkedFilesEditDialogViewModel.java

@@ -102,19 +102,19 @@ public void setValues(LinkedFile entry) {
        }
    }

-    public StringProperty linkProperty() {
+    public StringProperty link() {
        return linkProperty;


Sorry, I wasn't clear enough. The private field should be called link with public methods linkProperty() and get/setLink, with the latter optional.

…esDlg * upstream/maintable-beta: Reenable closing of entry preview by pressing Esc (#3883) # Conflicts: # src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java

Siedlerchr · 2018-03-26T18:25:30Z

I fixed all things open and did the renamings. So I merge this now

…drop * upstream/maintable-beta: (48 commits) Clean unused imports Fix missing icons and wrong package for custom icons Consistent FX color scheme for JabRef (#3839) javafx replacement for file dialog (#3005) Reenable closing of entry preview by pressing Esc (#3883) Load all field editors using ViewLoader Use JabRef icons in FXML Move icon stuff to new package gui.icon Load EntryEditor using new ViewLoader Improve tooltip tests Fix import thread problem Don't use null as parameter in DialogService Make it easier to create FXML dialogs (#3880) update slf4j from 1.8.0-beta1 -> 1.8.0-beta2 New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Greek) New translations Menu_en.properties (Greek) ... # Conflicts: # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java # src/main/java/org/jabref/gui/groups/GroupTreeController.java # src/main/java/org/jabref/gui/maintable/MainTable.java # src/main/java/org/jabref/logic/cleanup/MoveFilesCleanup.java # src/main/java/org/jabref/logic/cleanup/RenamePdfCleanup.java # src/test/java/org/jabref/logic/cleanup/MoveFilesCleanupTest.java # src/test/java/org/jabref/logic/cleanup/RenamePdfCleanupTest.java

…gsjavafx * upstream/maintable-beta: (188 commits) Fix checkstyle Exchange Ignore by Disabled (#3912) Remove all @author comments and empty method/class comments Clean unused imports Fix missing icons and wrong package for custom icons Consistent FX color scheme for JabRef (#3839) javafx replacement for file dialog (#3005) Reenable closing of entry preview by pressing Esc (#3883) Load all field editors using ViewLoader Use JabRef icons in FXML Move icon stuff to new package gui.icon Load EntryEditor using new ViewLoader Improve tooltip tests Fix import thread problem Don't use null as parameter in DialogService Make it easier to create FXML dialogs (#3880) update slf4j from 1.8.0-beta1 -> 1.8.0-beta2 New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java

Siedlerchr added 8 commits July 6, 2017 17:17

javafx replacement for file dialog

67ed3aa

Add some core structure for selectFilesDialog

136a844

Add Properties for binding

b3d7641

add getters

24c35c5

Renaming, use properties in controller

dfde523

open dialog with attach file action

Siedlerchr added this to the v4.1 milestone Aug 6, 2017

Siedlerchr added 2 commits September 23, 2017 20:04

port some more code

e099c2a

Siedlerchr commented Sep 23, 2017

View reviewed changes

Siedlerchr added 5 commits November 1, 2017 16:25

Asssign combobox selected value property

982b475

fix some formatting

9f5036d

LinusDietz modified the milestones: v4.1, v4.2 Nov 22, 2017

Siedlerchr commented Dec 29, 2017

View reviewed changes

Siedlerchr added 5 commits December 29, 2017 15:42

make getController public to get viewModel

81c25ec

Merge remote-tracking branch 'upstream/master' into selectFilesDlg

e71181a

* upstream/master: Refactor shared package into the architecture (#3523)

Merge remote-tracking branch 'upstream/master' into selectFilesDlg

d3daaa6

* upstream/master: Add oaDOI fulltext fetcher (#3581) Refactor export code to fix #3576 (#3578) Fix #3359: Automatically remove colon and apostrophe from key pattern (#3506)

add enum with config values instead of booleans

e326bcf

Siedlerchr mentioned this pull request Jan 7, 2018

Download no longer shows progress #3614

Closed

1 task

tobiasdiez mentioned this pull request Mar 24, 2018

Improvements around external file types #3887

Merged

6 tasks

Siedlerchr added 3 commits March 24, 2018 16:33

convert to new FXML dialog model funcionality

b5816bc

still some NPEs

fix empty lines

e1f85fd

fix checkstyle

8cb812d

Siedlerchr mentioned this pull request Mar 24, 2018

[WIP] Main table JavaFX migration #3621

Merged

35 tasks

Siedlerchr added 2 commits March 24, 2018 19:31

Fix viewModel NPE in copyFiles Action and linkedfilesEditDialog

0be175c

Add close button in copy linked files

45697c4

fix checkstyle

7d627ff

tobiasdiez requested changes Mar 25, 2018

View reviewed changes

Rename and reformat

3189b33

Siedlerchr commented Mar 25, 2018

View reviewed changes

Siedlerchr added 3 commits March 25, 2018 14:03

remove changelog

f579772

move fxml to java package remove wrapper class pass externalFileType to viewModel renammings

remove close method

95fdd2d

Add ok button to dialog pane

change some odd looking assigments

bb22a5e

tobiasdiez reviewed Mar 25, 2018

View reviewed changes

Siedlerchr added 3 commits March 25, 2018 17:55

renaming

035d9e2

forgotten rename

ce3d5e6

Merge remote-tracking branch 'upstream/maintable-beta' into selectFil…

c27c4d2

…esDlg * upstream/maintable-beta: Reenable closing of entry preview by pressing Esc (#3883) # Conflicts: # src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java

Siedlerchr merged commit 972cdc8 into maintable-beta Mar 26, 2018

Siedlerchr deleted the selectFilesDlg branch March 26, 2018 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

javafx replacement for file dialog #3005

javafx replacement for file dialog #3005

Siedlerchr commented Jul 13, 2017 •

edited

Loading

Siedlerchr Sep 23, 2017 •

edited

Loading

tobiasdiez Sep 24, 2017

Siedlerchr Sep 23, 2017

tobiasdiez Sep 24, 2017

koppor commented Nov 22, 2017

Siedlerchr Dec 29, 2017

tobiasdiez Dec 29, 2017

Siedlerchr commented Mar 24, 2018

tobiasdiez commented Mar 24, 2018

Siedlerchr commented Mar 24, 2018

tobiasdiez commented Mar 24, 2018

Siedlerchr commented Mar 24, 2018 •

edited

Loading

tobiasdiez left a comment

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

Siedlerchr Mar 25, 2018

Siedlerchr Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

Siedlerchr Mar 25, 2018

tobiasdiez Mar 25, 2018 •

edited

Loading

Siedlerchr Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

tobiasdiez Mar 25, 2018

Siedlerchr Mar 25, 2018

tobiasdiez Mar 25, 2018

Siedlerchr commented Mar 26, 2018

	viewModel.selectedKeyBindingProperty().bind(
	EasyBind.monadic(keyBindingsTable.selectionModelProperty())
	.flatMap(SelectionModel::selectedItemProperty)
	.selectProperty(TreeItem::valueProperty)
	);


		private void setBindings() {

		cmbFileType.itemsProperty().bindBidirectional(viewModel.externalFileTypeProperty());


		FileDirectoryPreferences getFileDirectoryPreferences();

		String get(String key);

javafx replacement for file dialog #3005

javafx replacement for file dialog #3005

Conversation

Siedlerchr commented Jul 13, 2017 • edited Loading

Siedlerchr Sep 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

koppor commented Nov 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Siedlerchr commented Mar 24, 2018

tobiasdiez commented Mar 24, 2018

Siedlerchr commented Mar 24, 2018

tobiasdiez commented Mar 24, 2018

Siedlerchr commented Mar 24, 2018 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tobiasdiez Mar 25, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Siedlerchr commented Mar 26, 2018

Siedlerchr commented Jul 13, 2017 •

edited

Loading

Siedlerchr Sep 23, 2017 •

edited

Loading

Siedlerchr commented Mar 24, 2018 •

edited

Loading

tobiasdiez Mar 25, 2018 •

edited

Loading