Fix #2775: Hyphens in last names are properly parsed #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
approved these changes
Sep 11, 2017
stefan-kolb
reviewed
Sep 12, 2017
|
|
||
| @Test | ||
| public void parseNameWithHyphenInLastNameWhenLastNameGivenFirst() throws Exception { | ||
| // TODO: Fix abbreviation to be "A." |
There was a problem hiding this comment.
Can you get this working too?
There was a problem hiding this comment.
Sadly no. I tried to fix it but the extraction of the abbreviation from the text is hidden in the whole tokenizing process and thus not easy to change.
LinusDietz
approved these changes
Sep 12, 2017
Siedlerchr
added a commit
that referenced
this pull request
Sep 13, 2017
Siedlerchr
added a commit
that referenced
this pull request
Sep 23, 2017
* upstream/master: (188 commits) Show file description only if not empty Add file description to gui and fix sync bug (#3210) Don't highlight odd rows in file list editor (#3223) Fix assertion by removing typo (#3220) Update assertion to change of online reference (#3221) Put in null return Reformatted code, renamed method, added try/catch Add tests for removal changes Improve telemetry (#3218) Real test linking real other entry (#3214) Check for explicit group at different location Update java-string-similarity from 0.24 -> 1.0.0 Only remove ExplicitGroups from entries, but not keyword-based groups Localization: French: Translation of a new string (#3212) Fix null return Changed from Path to Optional<Path> Fix #2775: Hyphens in last names are properly parsed (#3209) Followup to Issue #3167 (#3202) Remove unused import in GroupTreeNode Move getEntriesInGroup to GroupTreeNode ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed JabRef so much, that I even dared to touch the name parsing algorithm.
The only real changed consists in the few added lines https://github.com/JabRef/jabref/compare/fix3142?expand=1#diff-b8249d741d31352dd2bcafcab07d9457R147, the rest is only code formatting/renaming of variables. The added tests come from biblatex.
gradle localizationUpdate?