Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library properties: no change but... #3562

Closed
1 task done
mlep opened this issue Dec 21, 2017 · 2 comments · Fixed by #3579
Closed
1 task done

Library properties: no change but... #3562

mlep opened this issue Dec 21, 2017 · 2 comments · Fixed by #3579
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@mlep
Copy link
Contributor

mlep commented Dec 21, 2017

After opening the library properties window, if you click directly on OK, the file is shown as modified while no properties was modified by the user.

JabRef 4.1-dev--snapshot--2017-12-21--master--55abd5e2e
Linux 3.11-2-amd64 amd64
Java 1.8.0_131

Steps to reproduce:

  1. File -> New bibTeX library
  2. File -> Save library as...
  3. Enter a file name, like test.bib
  4. Click on OK
    Note that, at this point, the file is not shown as modified (no star in the name tab). Which is ok.
  5. File -> Library properties
  6. Click on OK (without modifying any properties)
    The file is shown as modified (star in the name tab)

Nothing special in the console.
@tobiasdiez tobiasdiez added the bug Confirmed bugs or reports that are very likely to be bugs label Dec 21, 2017
@koppor koppor added the PE1718 label Dec 22, 2017
@PJozeph
Copy link
Contributor

PJozeph commented Dec 24, 2017

can I work on this ?

@Siedlerchr
Copy link
Member

Sure, go ahead

PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 25, 2017
@PJozeph
fix issue JabRef#3562
a6f67b2
@PJozeph PJozeph mentioned this issue Dec 25, 2017
Merged
6 tasks
PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 25, 2017
@PJozeph
fix issue JabRef#3562 (fix typo)
5d92845
PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 29, 2017
@PJozeph
fix issue JabRef#3562 (inline)
515728d
PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 29, 2017
@PJozeph
fix issue JabRef#3562 (inline 2)
96b082b
PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 29, 2017
@PJozeph
fix issue JabRef#3562 (inline 2)
e1a2d2d
PJozeph added a commit to PJozeph/jabref that referenced this issue Dec 29, 2017
@PJozeph
fix issue JabRef#3562 (checkstyleMain)
3005e5a
tobiasdiez pushed a commit that referenced this issue Dec 31, 2017
@PJozeph @tobiasdiez
Library properties: no change but.. (issue #3562) (#3579)
504f7d8 
* fix issue #3562

* fix issue #3562 (fix typo)

* fix issue #3562 (inline)

* fix issue #3562 (inline 2)

* fix issue #3562 (inline 2)

* fix issue #3562 (checkstyleMain)
Siedlerchr added a commit that referenced this issue Jan 2, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
d4aed9b 
* upstream/master:
  Remove dependency to jgoodies-looks (#3458)
  Add simple gui test (#3399)
  Library properties: no change but.. (issue #3562) (#3579)
  Initialize previe before MainPanel to prevent NPEs on delete Fixes #3584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Library properties: no change but.. (issue #3562) PJozeph/jabref
5 participants
@Siedlerchr @koppor @tobiasdiez @mlep @PJozeph