Reenable closing of entry preview by pressing Esc #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
35 tasks
|
Still leaves the problem with clear search and close both using esc |
|
But I think it will now have the effect that if you clear the search the entry editor will be closed as well. |
|
No, it does not (just tried it out to make sure). |
Siedlerchr
approved these changes
Mar 24, 2018
Siedlerchr
reviewed
Mar 24, 2018
| @@ -143,7 +143,7 @@ public void actionPerformed(ActionEvent e) { | |||
| updateOpenCurrentResultsTooltip(globalSearch.isSelected()); | |||
| focus(); | |||
| event.consume(); | |||
| } else if (keyBinding.get().equals(KeyBinding.CLEAR_SEARCH)) { | |||
| } else if (keyBinding.get().equals(KeyBinding.CLOSE)) { | |||
There was a problem hiding this comment.
I would prefer a switch case here like in the other dialogs to have it consistent
There was a problem hiding this comment.
Me too, but I'm too lazy right now to change it 😄
|
If you fix the checkstyle issuie it's a go for me |
Siedlerchr
added a commit
that referenced
this pull request
Mar 26, 2018
…esDlg * upstream/maintable-beta: Reenable closing of entry preview by pressing Esc (#3883) # Conflicts: # src/main/java/org/jabref/gui/openoffice/StyleSelectDialog.java
Siedlerchr
added a commit
that referenced
this pull request
Mar 30, 2018
…drop * upstream/maintable-beta: (48 commits) Clean unused imports Fix missing icons and wrong package for custom icons Consistent FX color scheme for JabRef (#3839) javafx replacement for file dialog (#3005) Reenable closing of entry preview by pressing Esc (#3883) Load all field editors using ViewLoader Use JabRef icons in FXML Move icon stuff to new package gui.icon Load EntryEditor using new ViewLoader Improve tooltip tests Fix import thread problem Don't use null as parameter in DialogService Make it easier to create FXML dialogs (#3880) update slf4j from 1.8.0-beta1 -> 1.8.0-beta2 New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Greek) New translations Menu_en.properties (Greek) ... # Conflicts: # src/main/java/org/jabref/gui/actions/CleanupAction.java # src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java # src/main/java/org/jabref/gui/groups/GroupTreeController.java # src/main/java/org/jabref/gui/maintable/MainTable.java # src/main/java/org/jabref/logic/cleanup/MoveFilesCleanup.java # src/main/java/org/jabref/logic/cleanup/RenamePdfCleanup.java # src/test/java/org/jabref/logic/cleanup/MoveFilesCleanupTest.java # src/test/java/org/jabref/logic/cleanup/RenamePdfCleanupTest.java
Siedlerchr
added a commit
that referenced
this pull request
Apr 1, 2018
…gsjavafx * upstream/maintable-beta: (188 commits) Fix checkstyle Exchange Ignore by Disabled (#3912) Remove all @author comments and empty method/class comments Clean unused imports Fix missing icons and wrong package for custom icons Consistent FX color scheme for JabRef (#3839) javafx replacement for file dialog (#3005) Reenable closing of entry preview by pressing Esc (#3883) Load all field editors using ViewLoader Use JabRef icons in FXML Move icon stuff to new package gui.icon Load EntryEditor using new ViewLoader Improve tooltip tests Fix import thread problem Don't use null as parameter in DialogService Make it easier to create FXML dialogs (#3880) update slf4j from 1.8.0-beta1 -> 1.8.0-beta2 New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations Menu_en.properties (Italian) ... # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that we had a few key-bindings that were bound to
Esc, but only the first binding was returned (e.g. user pressedEsc, was recognized asDialogClosebut preview only reacted onEntryPreviewClose).