Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External changes of open entry are not synced-back to the entry editor #2946

Closed
tobiasdiez opened this issue Jun 28, 2017 · 7 comments
Closed

External changes of open entry are not synced-back to the entry editor #2946

tobiasdiez opened this issue Jun 28, 2017 · 7 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor

Comments

@tobiasdiez
Copy link
Member

Changes like generating a new bibtexkey or renaming the file are not displayed in the entry editor.
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-editor labels Jun 28, 2017
@tobiasdiez tobiasdiez added this to the v4.0 milestone Jun 28, 2017
This was referenced Jul 11, 2017
Closed
Closed
@lenhard
Copy link
Member

lenhard commented Jul 11, 2017

@tobiasdiez Is it possible that the ObjectBinding between the editor and the BibEntry breaks when you change something in the map of its fields, for instance by calling fields.put()? Can you please have a look at that?

@lenhard
Copy link
Member

lenhard commented Jul 13, 2017

@tobiasdiez Sorry, but this one is not fixed yet. It works now if you change something in the source tab. Then the changes are synced back to the field editor.

But it does not work in case of external changes. If you apply save actions, the changes only become visible if you reopen the file. If you change the file externally in a text editor, the changes become visible in the main table but not in the entry editor. They only become visible when the entry editor is recreated.

@lenhard lenhard reopened this Jul 13, 2017
@tobiasdiez
Copy link
Member Author

I tried it with the "convert to biblatex" cleanup and it worked (the year was moved to date and this change was correctly shown in the entry editor). Same with the "generate bibtex key" action.
What do I have to do to reproduce the problem you described?

@lenhard
Copy link
Member

lenhard commented Jul 13, 2017

@tobiasdiez I'll have to correct myself regarding safe actions. They do work. But the external changes don't. Do the following:

  1. open a bib file in jabref and a text editor (e.g. notepad++)
  2. change the content of the author field in notepad to something else, say test
  3. Go back to JabRef, the files changed dialog pops up. Accept the changes
  4. Now, the new author is displayed in the main table, but not in the entry editor.

@tobiasdiez
Copy link
Member Author

Ok, probably the merge dialog deletes the old bibentry and creates a new one instead of updating the one already present in the database. Thus the binding to the entry editor gets destroyed.
Should I create a new issue for this or do we silently ignore this problem until someone complains? 😄

@lenhard
Copy link
Member

lenhard commented Jul 13, 2017

That's the clue. The review panel says that there's an entry added and an entry removed, so that's why the relation breaks.

So that's not really critical, since I don't see the use case. Why would someone change the exact same entry in JabRef and a text editor in parallel, except if it's me who's testing. If a different entry is changed, the entry editor is recreated anyway.

Let's keep this open and I'll rename it and remove it from the 4.0 milestone.

@lenhard lenhard changed the title External changes are not synced-back to the entry editor External changes of open entry are not synced-back to the entry editor Jul 13, 2017
@lenhard lenhard removed this from the v4.0 milestone Jul 13, 2017
Siedlerchr added a commit that referenced this issue Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
f4a58c3 
* upstream/master: (30 commits)
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
  Eclipse J
  Add switch indentation for Eclipse and add some new missing formatting options
  ...
Siedlerchr added a commit that referenced this issue Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
6512fc6 
* upstream/master:
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
@matthiasgeiger matthiasgeiger mentioned this issue Aug 8, 2017
Closed
@lenhard lenhard mentioned this issue Aug 25, 2017
Merged
6 tasks
@lenhard
Copy link
Member

lenhard commented Aug 27, 2017

The remaining part is fixed by #3156.

@lenhard lenhard closed this as completed Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lenhard @tobiasdiez