Replace Reimplement MappedList.kt #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusDietz
added
build-system
status: ready-for-review
stefan-kolb
approved these changes
Jul 20, 2017
Siedlerchr
approved these changes
Jul 20, 2017
tobiasdiez
reviewed
Jul 25, 2017
|
|
||
| @Override | ||
| public A get(int index) { | ||
| return mapper.apply(super.getSource().get(index)); |
There was a problem hiding this comment.
This implementation of the MappedList looks identical to the one in the EasyBind package but is different from MappedList.kt.
The mapped list from the corda package runs the mapper when the item is inserted/updated while this implementation here invokes the mapper on every get-call. Since the get method is called relatively often (e.g. if you scroll in the listview), the EasyBind implementation should only be used for quick mappers. Can you please revert the change and/or write a direct reimplementation of the corda mapped list since we otherwise run again in performance problems with huge groups trees.
Siedlerchr
added a commit
that referenced
this pull request
Jul 31, 2017
* upstream/master: (41 commits) update xmlunit from 2.3.0 -> 2.4.0 update wiremock from 2.6.0 -> 2.7.0 update controlsfx from 8.40.12 -> 8.40.13 Fix group freeze by running markBasechange in swing thread (#3058) Localization: French: translation of new entries (#3050) Fix ads fetcher (#3048) Update translation (#3041) Translate new strings (#3040) Fix navigation in entry editor increases modifies font size (#3037) Initial idea for architectural decision records (#3033) Readd comment Readd comment Fix keybdining in entry editor in localized installation (#3030) Structuring Upgrade shadowJar Modernizer improvements Replace Reimplement MappedList.kt (#3032) Use https for the maven ej-technologies repo Upgrade modernizer plugin Remove separator next to search bar ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3014.
I have mainly used this gist as an idea https://gist.github.com/TomasMikula/8883719, the alternative would have been https://gist.github.com/mikehearn/a2e4a048a996fd900656