-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javafx replacement for file dialog #3005
Changes from 49 commits
67ed3aa
f4a58c3
136a844
b6d43dc
b3d7641
24c35c5
8dca324
dfde523
6633d61
e099c2a
2296ea5
982b475
3b7e52d
dbca24f
9f5036d
5b797d4
81c25ec
d4aed9b
e71181a
d3daaa6
e326bcf
e64b406
32c3db2
3f85f65
34d4251
514cd49
5305d43
cb7096c
fbf8fdb
cc6f3b9
ae7af40
16f0b11
3f7c282
9d2df14
38e087e
298a28f
773d4cc
39a1092
058aaf6
210d645
ce8b9c2
3450c8d
b5816bc
e1f85fd
8cb812d
0be175c
45697c4
7d627ff
3189b33
f579772
95fdd2d
bb22a5e
035d9e2
ce3d5e6
c27c4d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
|
||
import javafx.event.ActionEvent; | ||
import javafx.fxml.FXML; | ||
import javafx.scene.control.ButtonType; | ||
import javafx.scene.control.TableColumn; | ||
import javafx.scene.control.TableView; | ||
import javafx.scene.paint.Color; | ||
|
@@ -28,11 +29,14 @@ public CopyFilesDialogView(BibDatabaseContext bibDatabaseContext, CopyFilesResul | |
this.setTitle(Localization.lang("Result")); | ||
this.setResizable(true); | ||
|
||
this.getDialogPane().getButtonTypes().addAll(ButtonType.CLOSE); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original button was labeled There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem was that with an only OK button I was not able to close the dialog neither via the X in the corner nor via the OK button. It needs to have at least a button with Type CANCEL_CLOSE There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Problem was that the OK button was not at the Dialog Pane, but inside the content and therefore did not work |
||
|
||
viewModel = new CopyFilesDialogViewModel(results); | ||
|
||
ViewLoader.view(this) | ||
.load() | ||
.setAsContent(this.getDialogPane()); | ||
|
||
viewModel = new CopyFilesDialogViewModel(results); | ||
} | ||
|
||
@FXML | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the changes in maintable-beta is currently in the changelog. Thus, for consistency, I would say remove it for the moment and add it to the list in #3621.