Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download no longer shows progress #3614

Closed
1 task done
tobiasdiez opened this issue Jan 6, 2018 · 1 comment
Closed
1 task done

Download no longer shows progress #3614

tobiasdiez opened this issue Jan 6, 2018 · 1 comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Jan 6, 2018 •
edited
Loading

recent master

Steps to reproduce:

  1. Create entry and go to General tab
  2. Click "Download from URL" button and insert a link to a relatively large PDF. Click ok.
  3. When the download starts an empty progress bar is displayed. However, the progress is not updated and the progress indicator is hidden immediately.
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs entry-preview ui entry-editor and removed entry-preview labels Jan 6, 2018
@Siedlerchr
Copy link
Member

Refs #3005

tobiasdiez added a commit that referenced this issue Mar 9, 2018
@tobiasdiez
Provides download option in context menu and fixes #3614
7714558
@tobiasdiez tobiasdiez mentioned this issue Mar 9, 2018
Merged
6 tasks
Siedlerchr added a commit that referenced this issue Mar 17, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into maintable-beta
cb7096c 
* upstream/master:
  Provides download option in context menu and fixes #3614 (#3824)
  Minor refactoring

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
#	src/test/java/org/jabref/architecture/TestArchitectureTests.java
#	src/test/java/org/jabref/gui/fieldeditors/LinkedFileViewModelTest.java
Siedlerchr added a commit that referenced this issue Mar 18, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into maintable-beta
ad8bfd4 
* upstream/master:
  Provides download option in context menu and fixes #3614 (#3824)
  Minor refactoring

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
#	src/test/java/org/jabref/architecture/TestArchitectureTests.java
#	src/test/java/org/jabref/gui/fieldeditors/LinkedFileViewModelTest.java
Siedlerchr added a commit that referenced this issue Mar 18, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into selectFil…
16f0b11 
…esDlg

* upstream/maintable-beta:
  Get rid of journal abbrev loader in linkedFiles (#3862)
  fix build, remove layout prefs, pass journal abbrev loader and prefs where necessary
  Watch main css file for change and reapply automatically (#3847)
  Provides download option in context menu and fixes #3614 (#3824)
  Minor refactoring

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java
Siedlerchr added a commit that referenced this issue Mar 26, 2018
@Siedlerchr
javafx replacement for file dialog (#3005)
972cdc8 
* javafx replacement for file dialog

* Add some core structure for selectFilesDialog

* Add Properties for binding

* add getters

* Renaming, use properties in controller
open dialog with attach file action

* port some more code

* Asssign combobox selected value property

* fix some formatting

* make getController public to get viewModel

* add enum with config values instead of booleans

* Fix depdendency injection

* Rework

* Merge remote-tracking branch 'upstream/master' into maintable-beta

* upstream/master:
  Provides download option in context menu and fixes #3614 (#3824)
  Minor refactoring

# Conflicts:
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
#	src/test/java/org/jabref/architecture/TestArchitectureTests.java
#	src/test/java/org/jabref/gui/fieldeditors/LinkedFileViewModelTest.java

* Create Wrapper to pass LinkedFile around
TODO: what do to on edit? How to save the new file?

* fix some indentations
update File after Edit

* remove open unknown external file type dialog
convert ImportInspectionDialog to use new file edit dialog

* fix indentation

* convert attachFileDialog to javafx
show file open dialog on attach file
show dialog for editing file afterwards

* reformat

* Mark old filelist as deprecated
Pass Preferences Service instead of Preferences

* fix checkstyle
remove unused parameter entry

* fix checkstyle again

* add changelog
Move fxml to resources
rework layout to grid

* adjust indentation

* convert to new FXML dialog model funcionality
still some NPEs

* fix empty lines

* fix checkstyle

* Fix viewModel NPE in copyFiles Action and linkedfilesEditDialog

* Add close button in copy linked files

* fix checkstyle

* Rename and reformat

* remove changelog
move fxml to java package
remove wrapper class
pass externalFileType to viewModel
renammings

* remove close  method
Add ok button to dialog pane

* change some odd looking assigments

* renaming

* forgotten rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @tobiasdiez