Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set/clear/rename fields: append to a field #2721

Closed
buhtz opened this issue Apr 7, 2017 · 4 comments
Closed

Set/clear/rename fields: append to a field #2721

buhtz opened this issue Apr 7, 2017 · 4 comments
Labels
type: enhancement

Comments

@buhtz
Copy link

buhtz commented Apr 7, 2017 •
edited by koppor
Loading

The dialog in Quality -> Set/clear/rename fields has no way to append a value to a field.

e.g. I want to add a new keyword to multiple entries without losing the existing keywords.

There is a workaround for that:

Create a keyword-based group containing the expression you want to add and drag the entries onto this new group.

This works but is not the usual way of a user I think.
@koppor koppor added the beginner label Apr 7, 2017
@Anirudh257
Copy link

Hey, I am a newbie and I would love to help you out.

@koppor
Copy link
Member

koppor commented Jun 13, 2017

@Anirudh257 Thank you for offering your help. Have you seen https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md? We hope that you have IntelliJ in place. This will help you much.

@tobiasdiez
Copy link
Member

@Anirudh257 As a starting point have look at the class https://github.com/JabRef/jabref/blob/7a1b15abb58016b40e21a72124edf9da17cd08f2/src/main/java/org/jabref/gui/actions/MassSetFieldAction.java that handles the "Set/clear/rename fields" functionality. If you need further help, just ask here (or create a PR with your initial ideas).

@Anirudh257
Copy link

Sure, i will take a look into it.

@ethanwharris ethanwharris mentioned this issue Nov 3, 2017
Merged
6 tasks
lenhard pushed a commit that referenced this issue Nov 8, 2017
@ethanwharris @lenhard
Fix for issue #2721 append to a field (#3395)
f2744d4 
* Add append button (no functionality) to the user interface under Quality -> set/clear/rename fields

* Add functionality to append button under Quality -> Set/clear/append/rename fields

* Update Localization for set/clear/append/rename fields dialog

* Update CHANGELOG.md

* Rename variables (ce -> compoundEdit, oldVal -> oldValue, text -> textToAppend / Set etc.) for review and rename some variables from old code to match.

* Prevent re-assignment of parameter in massAppend method

* Rename TextField variables for clarity

* Revert localisation for set/clear/appen/rename_fields to original from set/clear/rename_fields
Siedlerchr added a commit that referenced this issue Nov 10, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
fac2c3d 
* upstream/master: (26 commits)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this issue Nov 18, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into linuxlink
b60fbfe 
* upstream/master: (23 commits)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  Strip invalid prolog when loading CitationStyles (#3404)
  Integrity check "Abbreviation Detection" detects abbreviated names for journals and booktitles based on the internal list instead of only looking for "." signs. (#3362)
  Update gradle from 4.2.1 to 4.3
  ...
Siedlerchr added a commit that referenced this issue Nov 19, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
dbca24f 
* upstream/master: (30 commits)
  Add Hint for checking master version (#3439)
  Replace LinkedFiles backslashes with forward slashes (#3403)
  fix isbn result from chimbori (#3442)
  Feature java version check again (#3428)
  Fix test for quoted lang messages (#3424)
  Update gradle from 4.3 to 4.3.1
  Fix #3411: ordering of fields in customized entry types works again (#3422)
  Backport of syncLang to python2 (#3420)
  Remove Versioneye badge
  Fix some error prone warnings
  Fix for issue #2721 append to a field (#3395)
  Fix travis - hopefully
  Remove 3.x changelog (#3250)
  Try to use hint of https://github.com/TheBoegl/shadow-log4j-transformer#usage-as-library
  Try to enable LGTM
  Update guava from 23.2 -> 23.3 (#3409)
  Update wiremock from 2.8.0 -> 2.10.1
  Move groups field from others to general (#3407)
  Fix checkstyle issues to repair build
  Fix #3046: No longer allow duplicate fields in customized entry types (#3405)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@koppor @tobiasdiez @buhtz @Anirudh257