Convert entry preview panel to JavaFX #3574
Merged
+414
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
6 tasks
Siedlerchr
reviewed
Dec 24, 2017
| } | ||
|
|
||
| public static JFXPanel wrap(Scene scene) { | ||
| JFXPanel container = OS.LINUX ? new CustomJFXPanel() : new JFXPanel(); |
There was a problem hiding this comment.
Good observation. Fixed.
Siedlerchr
approved these changes
Dec 24, 2017
tobiasdiez
force-pushed
the
JabRef/javafxPreview
branch
3 times, most recently
from
ba60126 to
b94c176
Compare
tobiasdiez
force-pushed
the
JabRef/javafxPreview
branch
from
b94c176 to
44fe17f
Compare
|
I'll merge this PR now so that I can continue working on the JavaFX migration. If you have further remarks, I'm happy to implement your suggestions. |
Siedlerchr
added a commit
that referenced
this pull request
Dec 28, 2017
* upstream/master: (121 commits) Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ExportFormats: Use FileExtension enum (#3565) Update guava from 23.5-jre -> 23.6-jre ... # Conflicts: # build.gradle
6 tasks
Siedlerchr
added a commit
that referenced
this pull request
Dec 29, 2017
* upstream/master: (234 commits) Fix checkstyle Fix tests Fix fetcher tests (#3583) Convert entry preview panel to JavaFX (#3574) Remove dependency for JUnit4 (#3580) Update tracis cache config as recommned by the docs (#3575) fix typo Show development information Release v4.1 Add new authors to mailMap (#3567) Fix build Really fix changelog Fix changelog Minor changes Disable the autocompletion as default (#3569) Add update exception for applicationinsights 2.0.0-BETA (#3571) Install4j jres 152 (#3570) Fix grammar mistake Downgrade applicationinsights. Fixes #3561 Adapt scripts/prepare-install4j.sh to JRE1.8.0_152 (#3568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3504 in a new PR since I am once again to stupid for git.
I now implemented it using latex2html and it seems to work quite well.
gradle localizationUpdate?