Deploy Checklist: Expensify.cash 2021-04-13

[OSBotify]

Release Version: 1.0.34-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add Emoji Picker #1991
• [No QA] fixed keyboard appears on split bill page #2022
• [No QA] Rename master to main in E.cash #2092
• [No QA] Created IOU preview component within chat #2112
• Refactor IOUAmountPage #2203
• Rename and restyle set password form #2211
• Display create menu within the chat area and add bottom up transition. #2222
• Fix typo #2297
• [IS-2151] fixed FAB issue #2305
• fix inline code blocks for native platforms #2307
• [No QA] Skip IOU participants step if launched from within chat #2321
• fix: ReportScreen is blank, indefinitely loading on web/desktop #2322
• Make New indicator permanent until navigating away from chat #2338
• Fix: Address bar URL is not updated after login or landing on root #2346
• Fix url parsing in chat messages #2355
• Refactor login form into a single component #2363
• Update version to 1.0.20-0 on master #2374
• Pass validateLinkPropTypes directly to prevent error #2375
• [No QA] Combine all platform deploys into one big file #2376
• Fix scrolling problem for LHN #2406
• adding payments line #2407
• [No QA] Use env and do not set SHOULD_DEPLOY_PRODUCTION #2412
• Fix popovers after regression #2424
• Add ability to dismiss attachment modal via swipe #2442
• Add link to all Upwork jobs to issue template #2443
• Fix keyboard bug when opening attachment modal #2460
• [No QA] Fix bash expansion in platformDeploy.yml #2461
• Remove step ID as it's not needed and causing errors #2464
• [No QA] Update caniuse browserlist to improve babel transpilation and resolve build warning #2467
• Remove emojis that are not implemented on mobile safari, and update header indices #2468
• Checkout code and set up npm for deploy code #2469
• Add native popover component #2474
• Add fetch depth 0 to fetch all tags #2475
• Offline status support for reportActionComposer #2478
• [No QA] Fix bugs found with staging deploy comments #2479
• Add indicators to let the user know if they are on staging or dev #2506
• Update contributing.md #2515
• Fix the IOU badge on newly created reports #2543
• Android - Main chat screen appears briefly when opening settings option #2549
• Revert "fix inline code blocks for native platforms" #2550
• Try naming VERSION to something else to not conflict #2558
• [No QA]Remove use of JSON.parse() to fix bug with version #2563
• fix: splash screen slightly jumps #2567
• Fix: Blank screen after creating an account #2575
• Update app with new branding #2576
• Revert "Apply localization to all hard coded text" #2579
• Revert "fix: splash screen slightly jumps" #2581
• Allow button presses while keyboard is up on Android #2586
• Only show environment badge next to chats header #2593
• Update favicons to have white background color #2603
• Update definition of BootSplash hide on Non-Native platforms #2619
• fixed unread message indicator UI #2624

Deploy Blockers:

• Add Emoji Picker #1991
• Cursor isn't properly returning to compose box during chat and or after switching chats #2403
• Copy - Copy banner when using right click button on message too large #2420
• Fix popovers after regression #2424
• iPad - Chat - App layout breaks when app re-opened from background #2445
• Emoji picker - Box changes size when you search for an emoji on Windows Chrome #2446
• iPad - Chat - Chats are not accessible on iPad in Portrait mode (Pay on June 15th) #2447
• Fix keyboard bug when opening attachment modal #2460
• [Hold for payment 5/7] Blank screen after creating an account #2497
• Search feature is not working #2538
• 2FA - Unable to log in with 2FA enabled. Stuck on loading screen #2548
• Android - Chat - Text field is hidden by keyboard once it is called #2577
• Revert "Apply localization to all hard coded text" #2579
• Signing out yields strange SignIn Screen URL Format #2620

cc @Expensify/applauseleads

[isagoico]

Regression is finished!
2 Issues found:

1. iOS - App option not available when tapping deep link #2401
2. Cursor isn't properly returning to compose box during chat and or after switching chats #2403 - Deploy Blocker

PRs are finished too.
3 comments added:

1. Refactor IOUAmountPage #2203 (comment) - Expected behaviour
2. [No QA] fixed keyboard appears on split bill page #2022 - We don't have access to the split bill feature to test this.
3. Fix: Address bar URL is not updated after login or landing on root #2346 (comment) - Deploy Blocker

Thanks!

[roryabraham]

Unlocking and relocking to see if GitHub's wonkiness with the branch rename will self-resolve.

[roryabraham]

Okay, staging seems to be back to normal. Going to unlock this, because Applause is getting a day off of QA due to the technical issues we had today. We'll resume QA tomorrow with a clean slate 😄

[isagoico]

Regression is finished!
3 Issues found:

1. iPad - Chat - App layout breaks when app re-opened from background #2445
2. Emoji picker - Box changes size when you search for an emoji on Windows Chrome #2446
3. iPad - Chat - Chats are not accessible on iPad in Portrait mode (Pay on June 15th) #2447

PRs are finished too.
3 comments added:

1. Fix scrolling problem for LHN #2406 (comment)
2. Add Emoji Picker #1991 (comment)
3. Add Emoji Picker #1991 (comment)

PR #2022 is still unchecked because, as mentioned here, #2022 (comment) we don't have access to the split bill feature to test this.

Thanks!

[roryabraham]

Looks like something weird happened here and the lock label was left on this issue over the weekend. Removing now, @isagoico feel free to re-add when you are ready to begin QA

[isagoico]

Mmm weird I just added it a few minutes ago so we can start QA

[roryabraham]

Oh, sorry about that. This is what I'm seeing:

My mistake @isagoico, but maybe in the future it's best to comment saying "starting QA now" or something so the chain of events is a little clearer.

[roryabraham]

I saw "you added and removed the label", but then the label was still on the issue... confusing 😕

[isagoico]

No worries at all :). that's indeed weird 🤔 this is how it's displayed on my end

That's a great idea. I'll start leaving a comment here when we start QA

[roryabraham]

Must be because I don't use darkmode

[roryabraham]

Sorry for the troubles today, unlocking again, and can relock after #2461 is merged.

[isagoico]

Regression is finished!
1 issue found:

1. Desktop - Emojis overlap without proper space formatting #2500

PRs are finished too
3 comments added:

• Add ability to dismiss attachment modal via swipe #2442 (comment) - will be solved separately
• Fix keyboard bug when opening attachment modal #2460 (comment)
• Fix keyboard bug when opening attachment modal #2460 (comment)

Thanks!

---

Status of unchecked PRs below:

1. Add Emoji Picker #1991 - still has unresolved issues
2. [No QA] fixed keyboard appears on split bill page #2022 - we don't have access to the split bill feature to test this.
3. Fix: Address bar URL is not updated after login or landing on root #2346 - has unresolved issue
4. Fix scrolling problem for LHN #2406 (comment) - internally tested

[isagoico]

Regression is finished!
1 issue found today.

1. Win / Chrome - Emoji flags are not displayed, only country codes  #2521

PRs are finished too.
1 comment added:

1. fix inline code blocks for native platforms #2307 (comment) - this deploy blocker was not added to the deploy blocker checklist.

Thanks!

[marcaaron]

Checking off #2406 since the LHN is working OK now.

[Julesssss]

Left this comment on this PR #2321 (comment) (doesn't look QAble by us)

Can confirm this can't be tested externally. I've marked it off the list.

[isagoico]

Regression is finished!
No issues found today.

PRs are finished too
1 comment added:

1. Fix keyboard bug when opening attachment modal #2460 (comment)

#2346 is still failing being fixed here #2497

Thanks!

[roryabraham]

As discussed in the issue, we're going to remove the DeployBlockerCash label from #2446 and check it off the deploy checklist. We're still going to fix it, but we don't think the bug is severe enough that it needs to block the deploy.

[roryabraham]

btw @isagoico this annoying GH bug is back... this is what I'm seeing on the issue right now:

But I know you added the lock label just a few hours ago. I'm not sure what the process is for reporting bugs on GitHub, but in the interim can you please just leave a comment when you add the lock label so that the audit trail is clearer? Normally you wouldn't have to, but it is just a workaround for the time being.

[isagoico]

Regression is done. Removing the lock label!

[isagoico]

Chat Regression is finished!
2 issues found today:

1. Android - Chat - Text field is hidden by keyboard once it is called #2577 Deploy blocker
2. Chat - Attachment picker is briefly displayed after taking picture to upload in chat #2580

[isagoico]

Starting QA setup! Adding the lock label

[roryabraham]

Sorry @isagoico, I am expecting the iOS deploy to fail. We have a potential fix that was merged just moments after you added the lock label here (I am actually unsure whether or not that PR is included in the current deploy, but I think not). If the iOS deploy does indeed fail, we'll need to remove and reapply the lock label this morning.

[roryabraham]

Looks like the iOS deploy was a success, so you're good to begin QA @isagoico

[isagoico]

#2506 (comment) - Will be fixed separately, checking it off

[isagoico]

Regression is finished!
2 issues found today:

1. Web - After adding the emoji, cursor is not in the front of the message  #2601
2. Web - Chat - Scroll bar appears when adding emojis #2599

PRs are finished too!
1 comment added:

1. Add indicators to let the user know if they are on staging or dev #2506 (comment) - Will be fixed sepparately

Thanks!

[isagoico]

Starting QA! Adding the lock label

[isagoico]

Regression is finished!
No issues found today.

PRs are finished too!
No comments added 🎉

[roryabraham]

As commented in the issue, I removed the deploy blocker label from #2620 and checked it off on the checklist.

[marcaaron]

Checked off #2497

[isagoico]

Starting QA!

[isagoico]

Regression is finished!
1 issue found today

1. Favicon - Flashing NEW! Expensify.cash and icon without white background can be seen in tab  #2636

PRs are done too
No comments added.

[roryabraham]

So since #2636 is not a deploy blocker, we can run a prod deploy!
🎉 Hooray! 🎉

[roryabraham]