Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicons to have white background color #2603

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

shawnborton
Copy link
Contributor

Details

This fixes the favicons on web by giving them a white background.

Fixed Issues

Fixes #2595

Tests

  1. Visually inspect the favicon in web when you have no unread messages, make sure it's updated.
  2. Visually inspect the favicon in web when you do have unread messages, make sure it's updated.

Tested On

This is web only.

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Unreads:
image

No unreads:
image

Mobile Web

N/A

Desktop

N/A

iOS

N/A

Android

N/A

@shawnborton shawnborton requested a review from a team April 27, 2021 23:57
@shawnborton shawnborton self-assigned this Apr 27, 2021
@shawnborton shawnborton changed the title $ https://github.com/Expensify/Expensify.cash/issues/2595 Update favicons to have white background color Apr 27, 2021
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team April 27, 2021 23:57
@Luke9389 Luke9389 merged commit 19df861 into main Apr 28, 2021
@Luke9389 Luke9389 deleted the shawn-favicons branch April 28, 2021 00:26
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.32-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favicon - Add white background to icon so $ is not lost in darker blackgrounds
3 participants