Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon - Add white background to icon so $ is not lost in darker blackgrounds #2595

Closed
isagoico opened this issue Apr 27, 2021 · 2 comments · Fixed by #2603
Closed

Favicon - Add white background to icon so $ is not lost in darker blackgrounds #2595

isagoico opened this issue Apr 27, 2021 · 2 comments · Fixed by #2603
Assignees

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Favicon should be clearly visible in darker backgrounds.

Actual Result:

$ is not visible in darker backgrounds

Action Performed:

  1. Navigate to staging.expensify.cash

Workaround:

No need for workaround, visual issue.

Platform:

Where is this issue confirmed?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.32-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @Beamanator https://expensify.slack.com/archives/C01GTK53T8Q/p1619544518130400

ISSUE: I believe there could be a slight issue with favicons on web -> When there’s no unread chats I see a favicon with white background, when there’s any unread chats I see the icon that looks like a transparent background - is that on purpose @shawn?

@isagoico isagoico added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 27, 2021
@shawnborton shawnborton assigned shawnborton and unassigned lschurr Apr 27, 2021
@shawnborton
Copy link
Contributor

Assigning myself, I can send an update for this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants