Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass validateLinkPropTypes directly to prevent error #2375

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

NikkiWines
Copy link
Contributor

cc: @marcaaron since you found this

Details

Passes validateLinkPropTypes directly instead of using objectOf which was causing a JS error.

Fixed Issues

Fixes N/A

Tests

  1. Log into an account on E.cash
  2. Open your developer console
  3. Navigate to the following URL http://localhost:8080/v/41/EGFEPALHG
  4. Confirm you don't see the following error in your console.
Warning: Failed prop type: Invalid prop `route.name` of type `string` supplied to `ValidateLoginPage`, expected `object`.

QA Steps

  1. Log into an account on E.cash on staging
  2. Open your developer console
  3. Navigate to the following URL http://staging.expensify.cash/v/41/EGFEPALHG
  4. Confirm you don't see the following error in your console.
Warning: Failed prop type: Invalid prop `route.name` of type `string` supplied to `ValidateLoginPage`, expected `object`.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A no UI changes.

Web

Mobile Web

Desktop

iOS

Android

@NikkiWines NikkiWines self-assigned this Apr 13, 2021
@NikkiWines NikkiWines requested a review from a team as a code owner April 13, 2021 18:29
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team April 13, 2021 18:30
@marcaaron marcaaron merged commit 94ba6da into master Apr 13, 2021
@marcaaron marcaaron deleted the nikki-fix-proptypes-error branch April 13, 2021 18:59
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants