Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update caniuse browserlist to improve babel transpilation and resolve build warning #2467

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

roryabraham
Copy link
Contributor

Details

When running webpack builds, we have had this warning:

[Renderer] Browserslist: caniuse-lite is outdated. Please run:
[Renderer] npx browserslist@latest --update-db
[Renderer] 
[Renderer] Why you should do it regularly:
[Renderer] https://github.com/browserslist/browserslist#browsers-data-updating

So I ran that command, verified that the warning is gone, and committed the diff. I also did some basic regression testing on web and desktop.

Fixed Issues

n/a, just cleanup.

Tests

Tests and QA should be covered by regular regression testing, I believe this is just updating the browser compatibility data used by the babel transpiler.

@roryabraham roryabraham requested a review from a team April 19, 2021 20:43
@roryabraham roryabraham self-assigned this Apr 19, 2021
@botify
Copy link

botify commented Apr 19, 2021

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team April 19, 2021 20:43
@jasperhuangg jasperhuangg merged commit d90aee4 into main Apr 20, 2021
@jasperhuangg jasperhuangg deleted the Rory-UpdateBrowserList branch April 20, 2021 02:05
@OSBotify
Copy link
Contributor

🚀 Deployed to staging 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants