Allow button presses while keyboard is up on Android #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 tasks
|
🚀 Deployed to staging in version: 1.0.32-3🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Previously for pages in the sign in flow, users weren't able to tap the buttons on the screen while the keyboard was up. I added
keyboardShouldPersistTaps, which should now allow this and reduce the number of taps required to login.Fixed Issues
Fixes #2546
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
This only shows it for the first screen in the flow, but I tested it for all of the other screens in the flow as well (Set Password Page, Password Form). I didn't include them because I didn't want my password in the screen recording.
https://user-images.githubusercontent.com/31285285/116174702-86ba4800-a741-11eb-8c94-2f4304f9fe23.mp4