Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch depth 0 to fetch all tags #2475

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add fetch depth 0 to fetch all tags #2475

merged 1 commit into from
Apr 19, 2021

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Apr 19, 2021

Details

Got farther in the new deploy process comments 🎉 However, we found another bug. We didn't have all the tags checked out so this git command was failing: git log --format="%s" 1.0.19-6...1.0.26-3 - This fix will resolve that error.

Fixed Issues

Fixes https://github.com/Expensify/Expensify.cash/runs/2385240576?check_suite_focus=true

Tests

  1. Merge this PR
  2. Verify there is a comment left on this PR (and a bunch of others) saying it was deployed to staging

@AndrewGable AndrewGable self-assigned this Apr 19, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner April 19, 2021 22:05
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team April 19, 2021 22:06
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, fingers crossed it works this time 😓

@roryabraham roryabraham merged commit dc7fecc into main Apr 19, 2021
@roryabraham roryabraham deleted the andrew-fetch-all branch April 19, 2021 22:12
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants