Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and restyle set password form #2211

Merged
merged 26 commits into from
Apr 27, 2021
Merged

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Apr 2, 2021

NOTE: I wasn't able to get git to recognize that the file was renamed, so the diff will show that the SetPasswordPage was deleted and that the SetPasswordForm is a new file.

Details

I renamed the SetPasswordPage into SetPasswordForm (seeing that it only contains the elements relevant to the form now), and changed it to use the same layout/styles as the LoginForm.

I also changed SignInPageLayout to use SafeAreaView seeing that all the forms who use it need to be wrapped by SafeAreaView.

Fixed Issues

Fixes Expensify/Expensify#157816

Tests

  1. Navigate to the SetPasswordPage
  2. Verify that it renders correctly
  3. Verify that the set password flow still works.

QA Steps

  1. Navigate to the sign in page. Enter an email address you have access to that doesn't exist. (use EmailOnDeck)
  2. Click the link in the email that was sent to you.
  3. Verify that the set password page renders correctly. Set a password.
  4. Sign out, and verify you can sign back in with that password.
  5. In addition, to verify that it renders correctly on mobile:
  • On native platforms, run npx uri-scheme open expensify-cash://setpassword/asdf --[ios/android] once you have the simulator running

Tested On

  • Web
  • Mobile Web
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-20 at 12 51 06 PM

Mobile Web

Screen Shot 2021-04-20 at 12 51 15 PM

iOS

simulator_screenshot_A856EB0A-BD07-4DAD-B63B-0FA9FC9AE969

Android

Screenshot_1618985799

@jasperhuangg jasperhuangg requested a review from a team as a code owner April 2, 2021 03:30
@jasperhuangg jasperhuangg self-assigned this Apr 2, 2021
@MelvinBot MelvinBot requested review from AndrewGable and madmax330 and removed request for a team April 2, 2021 03:30
@jasperhuangg jasperhuangg marked this pull request as draft April 2, 2021 03:34
@jasperhuangg jasperhuangg changed the title [HOLD Expensify.cash 2210] Rename and restyle set password form Rename and restyle set password form Apr 20, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review April 21, 2021 06:49
@jasperhuangg
Copy link
Contributor Author

@marcaaron Just marked this as ready for review, thanks!

src/pages/SetPasswordPage.js Outdated Show resolved Hide resolved
src/pages/SetPasswordPage.js Outdated Show resolved Hide resolved
src/pages/signin/SignInPage.js Outdated Show resolved Hide resolved
src/pages/SetPasswordPage.js Outdated Show resolved Hide resolved
src/pages/signin/SignInPage.js Outdated Show resolved Hide resolved
src/pages/SetPasswordPage.js Outdated Show resolved Hide resolved
@marcaaron marcaaron merged commit b09d981 into main Apr 27, 2021
@marcaaron marcaaron deleted the jasper-fixSetPasswordPage branch April 27, 2021 03:14
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.31-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

We were able to reproduce this while executing QA for this PR #2497. Apart from this it was a pass, checking it off.

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants