Favicon - Flashing NEW! Expensify.cash and icon without white background can be seen in tab

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Expected Result:

I expected no flashing with NEW! Expensify.cash and switching with Expensify.cash

Actual Result:

Flashing with NEW! Expensify.cash and switching with Expensify.cash

Action Performed:

1. Launch the app as Account B and log in
2. As account B, send some messages to account A
3. Go to https://staging.expensify.cash as Account A in Web/Chrome
4. Observe the favicons and NEW! Expensify.cash

Workaround:

No need, visual issue.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.34-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5045902_Recording__37.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[isagoico]

Issue reproducible during today's KI retests

[MelvinBot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

Looks like it has what it needs. Not labeling with "Demolition" because that label does not appear to be an option:

[deetergp]

This seems like a safe enough one for me to use to teach myself a bit more about ReactNative. Snagging it!

[isagoico]

Issue reproducible during today's KI retests

[deetergp]

I've spent some time digging into this today. The issue apperas to be that, although we are overriding the a listener inside componentDidMount in AuthScreens.js, something else is briefly overriding it after the first it mounts, setting the title back to Expensify.cash, until the component re-mounts.

I'm not entirely certain what that could be but I'll keep poking around to see if I can figure it out, and if I can't, I'll most likely end up pestering @marcaaron who, like a zen master, will present me with React Native koans till I stumble upon enlightenment.

[marcaaron]

What is a page title?

An alarm clock when the power returns.

[deetergp]

Ah-HAH! So it's line 43 in NavigationRoot.js that is squashing the (NEW!)… title. If I change the string from Expensify.cash to NavigationContainer this is what I see:

NavigationRoot.mp4

[marcaaron]

my work here is done