Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Main chat screen appears briefly when opening settings option #2549

Merged

Conversation

Maftalion
Copy link
Contributor

Details

  • Explicitly set cardStyleInterpolator on child stacks for better transition animation

Fixed Issues

Fixes #2107

Tests

  • Click your avatar to go to profile, go back and forth between the setting menu items

QA Steps

  • same as above

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-04-22.at.4.04.27.PM.mov

Mobile Web

Screen.Recording.2021-04-22.at.4.06.08.PM.mov

Desktop

Screen.Recording.2021-04-22.at.4.07.45.PM.mov

iOS

Screen.Recording.2021-04-22.at.4.01.26.PM.mov

Android

Screen.Recording.2021-04-22.at.4.11.59.PM.mov

@Maftalion Maftalion requested a review from a team as a code owner April 23, 2021 00:26
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team April 23, 2021 00:26
@joelbettner
Copy link
Contributor

LGTM 👍

@joelbettner joelbettner merged commit c8b5f30 into Expensify:main Apr 23, 2021
@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - Main chat screen appears briefly when opening settings option
3 participants