Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try naming VERSION to something else to not conflict #2558

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Try naming VERSION to something else to not conflict #2558

merged 2 commits into from
Apr 23, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

Trying to fix a broken workflow, I think having an env variable named VERSION and a with: variable named VERSION might be causing this issue, but this is a guess.

Fixed Issues

Fixes #2557

Tests

  1. Merge this PR
  2. Verify that a version is included in the deploy message when it goes out

@AndrewGable AndrewGable self-assigned this Apr 23, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner April 23, 2021 17:34
@MelvinBot MelvinBot requested review from Gonals and removed request for a team April 23, 2021 17:34
roryabraham
roryabraham requested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the input in markPullRequestsAsDeployed/action.yml too?

@AndrewGable
Copy link
Contributor Author

Ah yes, I forgot, good call.

roryabraham
roryabraham approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's do this thang.

@roryabraham roryabraham merged commit 51440b8 into main Apr 23, 2021
@roryabraham roryabraham deleted the andrew-fix-version branch April 23, 2021 17:58
@OSBotify OSBotify mentioned this pull request Apr 23, 2021
Closed
66 tasks
@AndrewGable AndrewGable mentioned this pull request Apr 23, 2021
Merged
@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VERSION not included as parameter for markPullRequestsAsDeployed
3 participants
@AndrewGable @OSBotify @roryabraham