Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try naming VERSION to something else to not conflict #2558

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Try naming VERSION to something else to not conflict #2558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4d0138
Try naming VERSION to something else to not conflict
AndrewGable Apr 23, 2021
77bdabe
Update action.yml
AndrewGable Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/markPullRequestsAsDeployed/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ inputs:
description: "Check if deploying to production"
required: false
default: "false"
VERSION:
DEPLOY_VERSION:
description: "The app version in which the pull requests were deployed"
required: true
GITHUB_TOKEN:
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/markPullRequestsAsDeployed/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const prList = JSON.parse(core.getInput('PR_LIST', {required: true}));
const isProd = JSON.parse(
core.getInput('IS_PRODUCTION_DEPLOY', {required: true}),
);
const version = JSON.parse(core.getInput('VERSION', {required: true}));
const version = JSON.parse(core.getInput('DEPLOY_VERSION', {required: true}));
const token = core.getInput('GITHUB_TOKEN', {required: true});
const octokit = github.getOctokit(token);
const githubUtils = new GithubUtils(octokit);
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/markPullRequestsAsDeployed/markPullRequestsAsDeployed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const prList = JSON.parse(core.getInput('PR_LIST', {required: true}));
const isProd = JSON.parse(
core.getInput('IS_PRODUCTION_DEPLOY', {required: true}),
);
const version = JSON.parse(core.getInput('VERSION', {required: true}));
const version = JSON.parse(core.getInput('DEPLOY_VERSION', {required: true}));
const token = core.getInput('GITHUB_TOKEN', {required: true});
const octokit = github.getOctokit(token);
const githubUtils = new GithubUtils(octokit);
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/platformDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ jobs:
with:
PR_LIST: ${{ steps.getReleasePRList.outputs.PR_LIST }}
IS_PRODUCTION_DEPLOY: ${{ env.SHOULD_DEPLOY_PRODUCTION == 'true' }}
VERSION: ${{ env.VERSION }}
DEPLOY_VERSION: ${{ env.VERSION }}
GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }}
ANDROID: ${{ needs.android.result }}
DESKTOP: ${{ needs.desktop.result }}
Expand Down