Update definition of BootSplash hide on Non-Native platforms #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperhuangg
requested review from
marcaaron and
a team
and removed request for
francoisl
robertjchen
approved these changes
Apr 29, 2021
|
LGTM! Merging now so that it can go out on the next deploy. |
66 tasks
|
🚀 Deployed to staging in version: 1.0.33-1🚀
|
|
🚀 Deployed to production in version: 1.0.39-5🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Before, we had a definition of
hidethat didn't support it returning a promise. Let's update it to include this so that people can use it without it breaking on non-native platforms. See issue for more on how this breaks stuff.Fixed Issues
Fixes #2618
Tests
Navigate to the sign-in page while logged out. Verify that it renders correctly.
QA Steps
Same as above tests.
Tested On
Screenshots
This only modifies an
index.jsfile (and not its correspondingindex.native.jsfile, so no native screenshots are needed.Web
Mobile Web
Desktop