Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank Screen and TypeError from BootSplash on Non-Native Platforms #2618

Closed
jasperhuangg opened this issue Apr 29, 2021 · 4 comments · Fixed by #2619
Closed

Blank Screen and TypeError from BootSplash on Non-Native Platforms #2618

jasperhuangg opened this issue Apr 29, 2021 · 4 comments · Fixed by #2619
Assignees

Comments

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 29, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

The sign in page should render without any issues.

Actual Result:

A blank screen appears, and a TypeError appears in the JS console:
Screen Shot 2021-04-29 at 8 35 48 AM

Action Performed:

Run Expensify.cash locally, navigate to whatever localhost URL it's served from.

Workaround:

Use mobile

Platform:

Web
Mobile Web
Desktop

@jasperhuangg jasperhuangg self-assigned this Apr 29, 2021
@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented Apr 29, 2021

Looks like it was caused by this PR: #2594. We need to update our definition of hide in src/libs/BootStrap/index.js to return a function that returns an object that has then defined.

@jasperhuangg jasperhuangg changed the title Blank Screen and TypeError from BootSplash on Web Blank Screen and TypeError from BootSplash on Non-Native Platforms Apr 29, 2021
@parasharrajat
Copy link
Member

oh yeah just sending a fix in few minutes.

@parasharrajat
Copy link
Member

Thanks for taking care of this @jasperhuangg. Let me know if you need anything from me.

@jasperhuangg
Copy link
Contributor Author

jasperhuangg commented Apr 29, 2021

@parasharrajat My bad for not seeing your comment sooner! I opened up the issue after I already wrote up a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants