Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cron script #4

Merged
merged 112 commits into from
Oct 19, 2024
Merged

Test cron script #4

merged 112 commits into from
Oct 19, 2024

Conversation

AdamRJensen
Copy link
Owner

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

kandersolar and others added 30 commits March 12, 2024 08:40
…1987)

* asv: bump minimum numpy and pandas versions

* try numpy 1.17.5?
* Update test_srml.py

* Update v0.10.4.rst
* remove numba version checking code

* set minimum numba in setup.py requirements

* remove same version check code in test_spa.py

* linter

* fix numba version check in `conftest.py`

* add `noqa: F401` to other import checks

* set minimum numba in pyproject.toml
* add example script and static plot images

* configure sphinx-gallery to not execute this one

* lint

* whatsnew

* fix backticks issue

* updates from review
* address the many pandas deprecation warnings

* roll back the change from M to ME

looks like ME only exists for pandas 2.2+

* lint
* finalize whatsnew

* Update docs/sphinx/source/whatsnew/v0.10.4.rst

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Create v0.10.5.rst

---------

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* Update plot_oedi_9068.py

* Update v0.10.5.rst

* Add thumbnail (hopefully)

* Multiline config vars not allowed?

* who knows if this works

* Trim extra spaces

* another try

* Another try, remove config from output

* Update conf.py

* Bad news, RTD works incrementally - locally it works

* Try to remove config option code block

* Update plot_oedi_9068.py

* Update plot_oedi_9068.py

* Update plot_oedi_9068.py
* Update additional pvlib publications

* Use DOI sphinx role
* Update test_singlediode.py

* Linter 🔧

* Update test_singlediode.py

* Change approach completely. Now we are mocking. 👷

* Thanks ruff for the formatting 💚
* move Matlab references to history

* whatsnew

* Update docs/sphinx/source/index.rst

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* Remove link to outdate tutorials

* Update link to min version requirements

* Remove correct tutorial link

* Remove more references to notebooks

* Update docs/sphinx/source/index.rst

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
list spectrum.spectral_factor_sapm, correct PVsyst capitalization
supply codecov upload token to codecov upload jobs
* change `np.Inf` to `np.inf`

AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.

* change `np.NaN` to `np.nan`

AttributeError: `np.NaN` was removed in the NumPy 2.0 release. Use `np.nan` instead.

* fix np.uint8 range issue

OverflowError: Python integer 450 out of bounds for uint8

* use `scipy.integrate.trapezoid` instead of `np.trapz`

DeprecationWarning: `trapz` is deprecated. Use `trapezoid` instead, or one of the numerical integration functions in `scipy.integrate`.

* advance minimum scipy from 1.5 to 1.6 for integrate.trapezoid

* whatsnew PR number
…` is provided (pvlib#2020)

* My approach to the issue

* Deprecate previous parameters

* No reason to over-engineer, right?

* Update v0.10.5.rst

* Update pvsystem.py

* Improve error handling

* Add ppl involved

* kevin's suggestions
* broken references in old whatsnews

* add missing ref to bishop88_* funcs

* this was interpreted as code (?)

* I think this messes up the indentation

* Fix unknown references in autosummaries

* This one too

* 🚀

* Undo calcparams_cec, I misread

* Aha, this is the right calcparams_ function

* Dammit, it's always the linter
* fix Ixx equation, use Aimp

* Update docs/sphinx/source/whatsnew/v0.10.5.rst

* lint

* lint

* get the spacing right

* more spacing

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
install an older version of conda in ASV CI job
* modify bishop88_mpp

* lint

* extend coverage to v_from_i, i_from_v

* lint

* whatsnew

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* require python >=3.8

* update CI configurations

* whatsnew

* remove pre-3.8 cruft

* fix h5py/numpy versioning issue for py3.8-min

* update gallery examples for newer pandas

* update asv config for python 3.8

* fix asv config syntax error

* one more asv config edit
* whatsnew cleanup

* add v0.11.0 file

* forgot to include myself in the contributors

* update release date

* Comments from review
* add mathjax config to conf.py

* mathjax3

* whatsnew

* v0.11 whatsnew
* fix indentation issues

* miscellaneous other math issues
…ntal_ratio. (pvlib#2021)

* PVlib Issue pvlib#1697 Remove the function and all its reference poa_horizontal_ratio.

* Added description, issue number, git hub user in the whats new of version 0.11.0
…ib#1962)

* Update shading.py

* Minimal test

* Implementation

From NREL paper

* Fix, fix, fix, fix & format

* Format issues

* Extend tests (compare with singleaxis) & format with ruff

* Format fixes

* Upgrade tests

* Array -> Axis

* type

* Whatsnew

* xd

* bruh

* Minor Python optimization a la tracking.singleaxis

* Comment and minor optimizations

* Surface -> Axis

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Elevation -> Zenith

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Elev -> Zenith

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update shading.py

* Update docstring

Co-Authored-By: Anton Driesse <9001027+adriesse@users.noreply.github.com>

* Add comments from `tracking.singleaxis`

Co-Authored-By: Will Holmgren <william.holmgren@gmail.com>
Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com>

* Singleaxis implementation port & test addition, based on old pvlib.tracking.singleaxis

* Update v0.10.4.rst

* Linter

* Code review

Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>

* Add Fig 5 [1] (still gotta check the built output)

* Add caption, change size and describe in alternate text

* rST fixes ?

* Figures have captions, images do not

https://pandemic-overview.readthedocs.io/en/latest/myGuides/reStructuredText-Images-and-Figures-Examples.html#id18

* Flip arguments order

* I forgot 💀

* Linter are you happy now?

* Remove port test and add edge cases test

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update test_shading.py

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Indentation xd

* Update test_shading.py

* I forgot how to code

* Align data

* Docstring suggestion from Kevin

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update link to example?

* add linear shade loss for thin films

* add tests, update docs, what's new

* fix what's new gh issue and pr links

* fix trailing whitespace

* responding to comments

- move linear shade loss to shading module
- don't use ternary, doesn't work on vectors, instead use np.where()
- set cross axis default to zero
- test vectors
- update docs

* update docstring for linear shade loss

- applicable to other monolithic thin film like CIGS, not just CdTe
- only when shade is perpendicular to scribe lines

* update example in linear_shade_loss

* add figure and formulas to shaded fraction

* shaded fraction consistently

* Add alternative text to image

* Update implementation based on PSZ PR. See description.

Commit highlights ✨ :
* I think I made all the code a bit more legible; sorry for the big changes @mikofski
* Tests a bit more complete (not much, still consider the same test data)
* Rename shaded fraction acronym from `fs` to `sf`
* Asserts changed to `assert_allclose` for a more legible output in case of failure

Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com>

* Whatsnew entries

Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com>

* Linter

* Clear things, convert Mark's reference to a reference

* Linter

* Update according to changes at PSZA PR

* Another commit, another try

* Ahhh, I rebased too fast

* whatsnews

* Update v0.10.4.rst

* Update v0.10.3.rst

* Rename to `shaded_fraction1d`, change params to `surface_*` instead of `tracker_*`

* Left this tracker refs behind

* Change rename in rst entries

* Add another testcase

* Improve docs references, clarify nomenclature

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update test_shading.py

* Remove linear_shade_loss

* First implementation of the new shaded fraction model (missing figure)

* Create Anderson_Jensen_2024_Fig3.png

* Update shading.py

* Update shading.py

* Update shading.py

* lintaaargggg

* Fill reference

* Next release 0.10.5?

* Fix tests

* Update test_shading.py

* Little improvement to table definitions

* Change `l` to `\ell`

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* `pvlib.tracking.projected_solar_zenith_angle` to `pvlib.shading.projected_solar_zenith_angle`

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* pitch references to `pitch`

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* `trackers_axis_azimuth` to `axis_azimuth`

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* whatsnews

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update v0.10.5.rst

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Change `tilt`s to `rotation`s and add `axis_tilt`

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Forgot to update tests 💀

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Add examples section

* roles assumption messin w/ me docs 😲

* roles assumption messin w/ me docs 😲

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update shading.py

* Update shading.py

* Add gallery example

* This was fixed in recent sphinx-gallery releases IIRC

* Extra empty line or admonition type unsupported

* Fix example link (hopefully 🙏  )

* Update shading.py

* Fix subsubsections?

* Nah, bulleted list didn't work

* tilted -> tracker, only affects text

* Typos and unreasonable physical values

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* See the Examples section below, not the unlinkable link

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* tracker -> row, param names, code and docs

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Fix broken example 🔧

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* "the row axis/axes" instead of ``axis_azimuth``

* Unnecessary math mode

Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Example suggestions and text trimming

Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* whatsmes

* Add test to fix coverage issue

* Apply suggestions from code review (Adam)

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update docs/examples/shading/plot_shaded_fraction1d_ns_hsat_example.py

* Update docs/examples/shading/plot_shaded_fraction1d_ns_hsat_example.py

---------

Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
Co-authored-by: Anton Driesse <9001027+adriesse@users.noreply.github.com>
Co-authored-by: Will Holmgren <william.holmgren@gmail.com>
Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>
Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* Remove deprecated basic_chain

* Remvoe basic_chain from docs and tests

* Update v0.10.2.rst

* Fix whatsnew files

* Implement reviewer comments
* Set leap_day=True

* Add whatsnew entry
pvlib#1989)

* Remove read_srml_month_from_solardat

* Add whatsnew

* Fix whatsnew files

* Update v0.11.0.rst

* Update docs/sphinx/source/whatsnew/v0.11.0.rst

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

* Implement code review changes

---------

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
* Update midc VARIABLE_MAP

* Add subscripts to dni mapping

* Update v0.10.5.rst

* Update midc.py

* Fix whatsnew entries

* Implement review changes
RDaxini and others added 27 commits September 17, 2024 10:33
* Implements closed-form solution for optimization problem in clearsky. Updates test.

* Revert "Implements closed-form solution for optimization problem in clearsky. Updates test."

This reverts commit 94259c5.

* Reintroduced changes without re-sorting the imports

* pep8 formatting adjustments

* Update whatsnew as per comments

---------

Co-authored-by: Andrew Godbehere <andrew.godbehere@leidos.com>
* Update example of shaded_fraction1d

* Update v0.11.1.rst
* fix spa numthreads warning interpolation

* add test

* get rid of the warning altogether

* whatsnew
* create split contributing page (initial)

besides splitting, some rearranging e.g. virtual environments section after pull requests section
some changing of headings for the new pages to make sense and avoid repetition

* Update v0.11.1.rst

* Update docs/sphinx/source/contributing/testing.rst

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

* add example gallery

---------

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
…pvlib#2055)

* Add clearsky.ipynb (Remove before merge)

* Fix clearsky.lookup_linke_turbidity to be timezone-aware

* Fix irradiance.get_extra_radiation to be timezone-aware

* Rerun and clear errors in clearsky.ipynb

* Remove clearsky.ipynb

* Update what's new

* Add docstring Notes to lookup_linke_turbidity

* Add tools._pandas_to_utc

* Update what's new

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* Add docstring Notes to _pandas_to_doy

* Revert _datetimelike_scalar_to_datetimeindex

* Revert tests.test_irradiance.times

* Replace lowercase utc with uppercase

* Fix clearsky lookup_linke_turbidity and _interpolate_turbidity

* Fix linter

* Fix clearsky._interpolate_turbidity to keep timezone

* Revert irradiance.py

* Clarify UTC input of ephem.Date

* Fix tz-naive delta_t of dni_extra nrel

* Fix tz-naive delta_t of get_solarposition nrel_numpy

* Avoid future midnight of location.get_sun_rise_set_transit spa

* Fix tz-naive delta_t of location.get_sun_rise_set_transit spa

* Fix local midnight of hour_angle and sun_rise_set_transit

* Fix dayofyear of solarposition decl and eot, i.e. clearsky.bird

* Fix dayofyear of spectrum.spectrl2 dni_extra spencer

* Fix monthly SeasonalTiltMount orientation

* Fix year and dayofyear of solrad

* Fix flake8

* resolve whatsnew

* don't change v0.11.0

* minor adjustment to test_clearsky

* undo edit to get_solrad

* undo edit to get_solrad

* Update pvlib/clearsky.py

* Update docs/sphinx/source/whatsnew/v0.11.1.rst

* Update docs/sphinx/source/whatsnew/v0.11.1.rst

* Update docs/examples/irradiance-transposition/plot_seasonal_tilt.py

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

* Revert benchmarks/benchmarks/solarposition.py

* Revert test_lookup_linke_turbidity_nointerp

* Revert solrad.py

* Revert plot_seasonal_tilt.py except notes

* Update test_sun_rise_set_transit_spa with delta_t

* Update test_nrel_earthsun_distance with delta_t

* Update test_sun_rise_set_transit_geometric with naive tz

* Update test_hour_angle with inversion and naive tz

* Remove _is_leap_year from _interpolate_turbidity

* Update docs/sphinx/source/whatsnew/v0.11.1.rst

---------

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…t `pvlib.irradiance` (pvlib#2191)

* Update irradiance.py

add eqn variable definitions
rearrange references
changed beta into theta_T to avoid double definition --- surface tilt, and "daily average of the solar elevation in degrees" (pvlib.irradiance.diffuse_par_spitters)

* Update irradiance.py

* Update irradiance.py

Remove Loutzenhiser P.G. et. al. reference. I do not see it cited anywhere here in the docs for the haydavies model

* Update irradiance.py

add "projection ratio" to variable definition

* Update irradiance.py

separate A and R_b

* Update irradiance.py

Change all instances of W/m^2 into Wm⁻²

* Update irradiance.py

W/m^2 to Wm⁻²

* Update irradiance.py

* add url to references

* Update irradiance.py

* unit typesetting suggestion

* Update irradiance.py

* Update irradiance.py

* Update pvlib/irradiance.py

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

* eqn typesetting

* minor wording edits

* Update v0.11.1.rst

* Update irradiance.py

adjust units

Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

* Update irradiance.py

* \theta_T -> \beta

* add last accessed to reference

* remove spurious period

* Apply suggestions from code review

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

* Update irradiance.py

Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>

* Update irradiance.py

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
* Create average_photon_energy.py

* Update average_photon_energy.py

* Update average_photon_energy.py

* Update average_photon_energy.py

continuing creation

* Update average_photon_energy.py

* Update average_photon_energy.py

* Update average_photon_energy.py

* Update average_photon_energy.py

* Update average_photon_energy.py

add interpretation of APE values underneath table

* Update average_photon_energy.py

* Update average_photon_energy.py

add ape table

* Update average_photon_energy.py

add last accessed to references

* Update average_photon_energy.py

wording, remove table

* Update average_photon_energy.py

reference order

* Apply suggestions from code review

Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com>

* Update average_photon_energy.py

* Apply suggestions from code review

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

* Update average_photon_energy.py

add =
variable names
remove unused package

* Update average_photon_energy.py

gallery example ref

* Update v0.11.1.rst

* Update docs/sphinx/source/whatsnew/v0.11.1.rst

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

* Update average_photon_energy.py

update legend

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

---------

Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
* Remove python version 3.8

* Add py3.9-min

* Update min numpy in pyproject.toml

* Update asv.conf.json

* Update v0.11.1.rst

* Update versions in asv.conf.json

* Bumping numpy version in asv.conf.json

* Update v0.11.1.rst

* Update codecov python version

* Remove dataclassees in requirements-py3.9-min.yml

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

---------

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* Update PVGIS TMY tests and files

* Update docs/sphinx/source/whatsnew/v0.11.1.rst
* Update to actions/setup-python@v5

* Update to actions/checkout@v4

* Bring up to pvlib#2218

* Address reviewer comments
* Update irradiance.py

move eqn and add description and variables definition to a new notes section
update references
redefine surface tilt for consistency with pvlib#2191

* Update irradiance.py

update variable names (I_d0 to DHI and add definition of theta as aoi)

* Update irradiance.py

add doi

* Update irradiance.py

wording in definition of F'

* Update irradiance.py

* Update irradiance.py

\theta->\beta
reinstate Loutzenhiser reference

* Update irradiance.py

add doi to

* Update irradiance.py

* Update irradiance.py

add units to returns statement

* typo

* Update v0.11.1.rst

* Update v0.11.1.rst

* update model description

* whatsnew, update and merge entries

* whatsnew (missing word)

* move references (klucher and haydavies)

moved references from first line to notes section
* code changes: allow delta_t to be array

* initial test updates

* whatsnew

* lint

* fix dtype issue

* more delta_t array tests

* optimize numba/numpy reloads and warnings

* more lint

* Update pvlib/spa.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* add test with varying delta_t

---------

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* add missing contributors

* set release date; misc whatsnew cleanup

* more whatsnew cleanup

* address review comments

Co-Authored-By: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

* tildes

---------

Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
* revise dc_ohmic_loss and dc_ohms_from_percent docstrings

* edits

* Apply suggestions from code review

Thanks @RDaxini

Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>

* raw docstring

---------

Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
* references, variable definition, notes section

* Update irradiance.py

* Update irradiance.py

* Update irradiance.py

consistent reference style

* Update irradiance.py

add date to sentence

* R_b definition

* Update v0.11.2.rst

* Apply suggestions from code review

Thanks for the review

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* extraterrestrial -> direct extraterrestrial

as per the paper (variable I_on)

* clarify horizontal irradiances definition

* theta_T->beta

---------

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Close pvlib#2239 update link to contributing from readme
* Update iam.py

* restore comment

* remove blank line

* Update iam.py

* sorry for the rapid commit spam

* Apply suggestions from code review

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

---------

Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
…deprecation period (pvlib#2237)

* Add renamed_kwarg_warning decorator

* Example at solarposition.hour_angle()

* another day, another test

* Flake8 strikes again

* Fix no warning test

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Add test to remember removing the deprecation decorator

* test-driven-development for the win: unchanged remain properties

Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>

* Update docs

* Update fail_on_pvlib_version test comment

* Rename&deprecate solarposition.sun_rise_set_transit_spa

* flake8

* flake8 no more

* date -> time in solarposition.sun_rise_set_transit_spa

* Change to ..versionchanged, same format.

* Apply suggestions from Adam

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Apply Adam review x2

Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update solarposition.py

* Update solarposition.py

* Revert solarposition and test_solarposition changes

* Had to use main instead of master xd

* 😭

---------

Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* Update variables_style_rules.csv

* update definition

Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>

* Update pvlib/data/variables_style_rules.csv

Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

---------

Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…#2262)

* Partially move `test_conftest` to `test__deprecation`

* Add no cover directive in a comment

* Update v0.11.2.rst
@AdamRJensen AdamRJensen merged commit b533057 into main Oct 19, 2024
19 of 20 checks passed
@AdamRJensen AdamRJensen deleted the test_cron_script branch October 19, 2024 15:11
AdamRJensen added a commit that referenced this pull request Oct 19, 2024
* prototype (#1)

* first iteration

* dynamic period

* docstring

* feedback

* linting

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* Update pvlib/iotools/solcast.py

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>

* midpoint docstring

* flak8 formatting

* PR 1875 (#2)

* kandersolar feedback (#3)

* addressing feedback from Kandersolar

* Review (#4)

added hack for ISO periods in Pandas 0.25 and clearsky parameter maps

* comment on pandas version

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Adams's feedback

* Update pvlib/iotools/solcast.py

Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>

* Adams's feedback

* Last minor changes

* added test for _get_solcast

* feat: add additional test coverage (#5)

Co-authored-by: Hugh Cutcher <hugh@solcast.com.au>

* linting

---------

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Co-authored-by: hugh-solcast <143680553+hugh-solcast@users.noreply.github.com>
Co-authored-by: Hugh Cutcher <hugh@solcast.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.