Main #5
Merged
Main #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* appease a few test warnings * missed a bunch of these first time around
* Update test_psm3_2019_5min.csv * whatsnew
* Added synk.io badge * Removes LGTM badges and repurposes the row to Synk Advisor * removes LGTM badges * making final changes to this PR * Add whatsnew note * Add bullet to lgtm entry --------- Co-authored-by: Pratham Chauhan <Prathamchauhan2002@gmail.com> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
…m3 (pvlib#1648) * Fix mapping of request variables * I've missed stickler * Add column order check * Fix typo * Update pvlib/tests/iotools/test_psm3.py Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov> * Add whatsnew entry * Update variable map --------- Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov>
…pvlib#1616) * [ENH] extend iam.physical with optional n_ar parameter for AR coating * [CLN] resolve stickler-ci failures; [ENH] ensure inputs could be vectors * [DOC] iam.physical: update docstring and add whatsnew entry * [CLN] minor non-functional change to improve readability * revert latest commit * apply suggested changes * update docstring, add contributors
* use 'nearest' instead of 'before' and 'after' * whatsnew
* add limit to gamma term, string_factor, tests * adjust existing test, whatsnew * spacing * remove extra line * review * trailing space
…ms (pvlib#1662) * add CEC vs Sandia and multiple inverter FAQs * Update docs/sphinx/source/user_guide/faq.rst Co-authored-by: Will Holmgren <william.holmgren@gmail.com> * incorporate reviewer feedback Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com> * fix whatsnew --------- Co-authored-by: Will Holmgren <william.holmgren@gmail.com> Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>
…syst_temperature_coeff (pvlib#1674) * use explicit finite difference instead of scipy.misc.derivative * whatsnew * private function in tools.py Co-Authored-By: Mark Mikofski <bwana.marko@yahoo.com> --------- Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>
…lib#1668) * Updating infinite_sheds irradiance engine Updating the infinite_sheds irradiance engine to use the haydavies sky diffuse model. This will help the sensitivity issue with circumsolar on the backside of bifacial systems. * update use solar_zenith and solar_azimuth, instead of projection_ratio, in the haydavies() call. * update removed unused functions from imports * adding test and updating reference Added test and updating documentation. * updates Corrected white-space errors and added test for when haydavies is selected, but dni_extra is not supplied. * updates Updated docstrings and implemented a second call to haydavies to avoid 1/cos(zenith) issues with DNI where zenith nears 90 deg. * Update reorganize order of function inputs. * Update Updated tests give have correct ordering of inputs. * update Whitespace errors - these will be the end of me! * Update Added detail to docstring in infinite_sheds.py and note on haydavies implementation in bifacial.rst (based on comments from PR). * Update bifacial.rst Updated bifacial.rst file for formatting and ordering. Had added note detailing to user what occurs when 'haydavies' model is selected.
* add new equation to get_relative_airmass * test * whatsnew * remove duplicate whatsnew entry * true -> apparent * fix merge error * Apply suggestions from code review Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> --------- Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* add Boland DF estimation * update what's new, add to docs * add example * finish example * trailing whitespace * respond to comments - put Badescu textbook before paper - revise wording defining kt * respond to comments - remove redundant kt definition - use intersphinx to link to pandas and numpy types * Update docs/examples/plot_diffuse_fraction.py responding to comments, simplify wording L12-15 to omit "systems often tilted to optimize performance..." Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Update docs/examples/plot_diffuse_fraction.py respond to comments, reword decomposition example intro Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * respond to comments - add intro before functions in example * respond to comments in diffuse fraction example - fix use :py:func: to xref functions in docs, instead of :meth: - add comment to explain conversion of mbars to Pa - use Gsc not E0 in kt comparison plot * respond to comments - add section to conclusions to warn users that TMY3 and NSRDB are also models, therefore not to assume differences are errors, and link to TMY3 & NSRDB documentation - use implicit targets to link to DISC, DIRINT, Erbs, & Boland sections - reverse change of scaled GHI by E0 to Gsc (aka: solar constant) - use math directive for DNI formula * respond to comments - revise & condense conclusions, don't refer to differences as errors without operational data - add header before plots section, explain why comparing normalized GHI - add subheaders for seasonal plots * fix stickler * update readthedocs.yml to v2 * oops, extra requires is doc, no s * use requirements to pin requirements * install pvlib again? * Revert "update readthedocs.yml to v2" This reverts commit ccf40a8. * update RTD config to fix shallow clone issue * Update pvlib/irradiance.py Use Sphinx math role to render k_t in docstring for min cosine zenith Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * use solar_zenith in irradiance.boland docstring since pvlib#1403 * update reference to modeling diffuse fraction by J. Boland, available online https://www.researchgate.net/publication/229873508_Modelling_the_diffuse_fraction_of_global_solar_radiation_on_a_horizontal_surface * let user pass boland coeffs as kwargs - add a_coeff, b_coeff to docstring params - update equation to match Boland paper, use A, B coeffs - update coeffs to match Boland paper too (8.6-> 8.645 and 5 -> 5.3 - add note to explain different coeffs for different time intervals - give coeffs for 15-min & 1-hr - update zenith to solar_zenith everywhere - update test expected to match output with new coeffs * move plot diffuse fraction example to subdir - create irradiance-decomposition subdir in gallery, add readme.rst - use complete_irradiance() to get DHI using closure eqn's * shift solar position calc to hour center - in plot diffuse fraction examples - add note to explain b/c TMY timestampe at hour end - reset index to align with TMY3 - fix Jan, July, Apr timestamp names didn't match actual times * don't need numpy in plot diffuse fraction examples * minor edits in plot diffuse fraction example - chnage df to be specific to disc or dirint - change date names to Jan-04, Jan-07, etc. instead of _AM, _PM etc. * Apply suggestions from code review by Adam * use lower case coeffs in equation * periods in docstrings * some wordsmithing * replace parameter types for datetime_or_doy with numeric * consistent def for kt is ratio of GHI to horizontal extraterrestrial-irradiance Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * fix stickler - long lines in plot SF example --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
…b#1573) * start to adding tests from data in ivcurves repo * correcting Vth calculation * making current increasing for numpy linear interp * singlediode ivcurve_pnts does not give negative voltage with brentq and newton * adding test for singlediode log spacing methods * adding assertions for i_x and i_xx * adding i_x, i_xx iv curve data * updating whatsnew * reverting changes to pvsystem.singlediode * move precise iv curve fixtures into test_singlediode * updating precise iv curve json to match new schema * testing v_from_i, i_from_v * small refactor * small refactor and update whatsnew * changing Boltzmann's constant * add more to precise iv curve docstring * use SciPy constants * restore whatsnew 0.9.4 * relax i_xx error tolerance * trying lower i_xx atol * update generated iv curves after finding bug in their calcuation * increasing i_xx atol, and adding comment about atol on mac, windows * update whatsnew * update whatsnew and add references to test docs
* update copyright * Update LICENSE remove current year * Update LICENSE * edit AUTHORS * restate copyholders and order * put PVLIB python Developers back * update authors * consistency
* use horner's method in disc * Update v0.9.5.rst update whatsnew * fix stickler, indentation in disc * fix underindentation stickler issue in disc * use is_clear instead of bools in disc * fix stickler indentation complaint for disc * fix stickler indent complaint in disc again * change is_clear to is_cloudy, fix hyperlink for whatsnew rst * Update v0.9.5.rst Fix link to Horner’s method
* New library file name in code. * Add csv file and whats new. * Update inverter test. * New library with new records appended to old. * Clean up comment, restore original test and update whatsnew. * Update v0.9.5.rst Clarify the nature of the dayabases. * Delete old csv file
…lt` (pvlib#1682) * vectorize _vf_ground_sky_2d across surface_tilt also a few other micro-optimizations * whatsnew * remove straggler instrumentation * docstring improvement * stickler * update failing test * remove "per-point" language * sprinkle in some `del`s * contorted version using numpy's `out` parameter * even more out * add vectorize kwarg to infinite_sheds * benchmark both vectorize=True and vectorize=False * improve comments * test coverage * stickler * Apply suggestions from code review Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * stickler --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
* add missed contributors; whatsnew cleanup * add blank v0.9.6 whatsnew * increment release date * minor RST improvements * fix underline too short warning in gallery page
* Update get_psm3 interval description * Update v0.9.6.rst
* cast to datetime64[s] in ecmwf test * fix for older pandas
…_irradiance` (pvlib#1720) * Made "data" argument in the mc.run_model_from_effective_irradiance as a required argument. * Maded "data" argument required for subfunction _prepare_temperature and _run_from_effective_irrad * Removed "default None" from docstring * Added bug fix comment in v0.9.6 and contributors name.
* Broken links Fixes : pvlib#1721 Signed-off-by: kshitiz305 <kshitiz305@live.com> * move whatsnew entry to Documentation section * add 0.9.6 whatsnew to whatsnew index --------- Signed-off-by: kshitiz305 <kshitiz305@live.com> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* resolved clarify f_x * done pep8 * tried autopep8 * updated whatsnew.rst * corrected whatsnew --------- Co-authored-by: Lakshya Garg <72099449+Lakshyadevelops@users.noreply.github.com>
* Update url * Update v0.9.6.rst * Update server docstring & add URL constant
…y url to new 3.2.2 endpoint (pvlib#1736) * update default endpoint to 3.2.2; add url parameter * whatsnew * test * Revert "test" This reverts commit 31dcd5d. * update 30-minute test file to 3.2.2 data * stickler @AdamRJensen * more data file updates
* Added map_variables param in read_tmy3 func * solved failing tests * solved failing tests * solving stickerly test fail * solving stickerly test fail * solving stickerly test fail * added variable_map * resolving formatting issues * Update pvlib/iotools/tmy.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Update pvlib/iotools/tmy.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Update pvlib/iotools/tmy.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Update pvlib/iotools/tmy.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Added tests to map_variables and check depreciation warning * resolving formatting issues * resolving formatting issues * Adding more test cases * updated VARIABLE_MAP * updates DOIs in tmy.py * Final changes as requested * Fix stickler * Update variables_style_rules.csv * Add missing map_variables=False * Add whatsnew deprecation entry * Apply suggestions from code review * Add separate if statement for warning * removed wrong whatsnew entry * Update pvlib/tests/iotools/test_tmy.py Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov> * Update warning messages according to table * Update whatsnew * Set recolumn=None * Update tests * Update pvlib/iotools/tmy.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update pvlib/iotools/tmy.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update docs/sphinx/source/whatsnew/v0.9.6.rst Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Implement updated error message logic from kansersolar * Clean up deprecation warnings * Fix clearsky.rst * Update aod variable mapping * Fix stickler * Update tmy3 variables names in field,description table * Update table * More table stuff * Table stuff galore --------- Co-authored-by: Pratham Chauhan <Prathamchauhan2002@gmail.com> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> Co-authored-by: Kevin Anderson <kevin.anderson@nrel.gov> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…inglediode` order. (pvlib#1719) * reorder i_from_v, v_from_i args and refactor tests * reorder args to _update_io v_from_i call * fix condition in type checks for i_from_v tests * reorder arguments for _lambertw methods * adding versionchanged directives * breaking changes section in whatsnew; edit v_from_i, i_from_v docstrings * "Breaking Changes" to "Breaking changes" to match casing of "Bug fixes" * rename I to current
* tilt -> surface_tilt * whatsnew * document surface_tilt as numeric, not float
* Implements closed-form solution for optimization problem in clearsky. Updates test. * Revert "Implements closed-form solution for optimization problem in clearsky. Updates test." This reverts commit 94259c5. * Reintroduced changes without re-sorting the imports * pep8 formatting adjustments * Update whatsnew as per comments --------- Co-authored-by: Andrew Godbehere <andrew.godbehere@leidos.com>
* Update example of shaded_fraction1d * Update v0.11.1.rst
* fix spa numthreads warning interpolation * add test * get rid of the warning altogether * whatsnew
* create split contributing page (initial) besides splitting, some rearranging e.g. virtual environments section after pull requests section some changing of headings for the new pages to make sense and avoid repetition * Update v0.11.1.rst * Update docs/sphinx/source/contributing/testing.rst Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> * add example gallery --------- Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
…pvlib#2055) * Add clearsky.ipynb (Remove before merge) * Fix clearsky.lookup_linke_turbidity to be timezone-aware * Fix irradiance.get_extra_radiation to be timezone-aware * Rerun and clear errors in clearsky.ipynb * Remove clearsky.ipynb * Update what's new * Add docstring Notes to lookup_linke_turbidity * Add tools._pandas_to_utc * Update what's new Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * Add docstring Notes to _pandas_to_doy * Revert _datetimelike_scalar_to_datetimeindex * Revert tests.test_irradiance.times * Replace lowercase utc with uppercase * Fix clearsky lookup_linke_turbidity and _interpolate_turbidity * Fix linter * Fix clearsky._interpolate_turbidity to keep timezone * Revert irradiance.py * Clarify UTC input of ephem.Date * Fix tz-naive delta_t of dni_extra nrel * Fix tz-naive delta_t of get_solarposition nrel_numpy * Avoid future midnight of location.get_sun_rise_set_transit spa * Fix tz-naive delta_t of location.get_sun_rise_set_transit spa * Fix local midnight of hour_angle and sun_rise_set_transit * Fix dayofyear of solarposition decl and eot, i.e. clearsky.bird * Fix dayofyear of spectrum.spectrl2 dni_extra spencer * Fix monthly SeasonalTiltMount orientation * Fix year and dayofyear of solrad * Fix flake8 * resolve whatsnew * don't change v0.11.0 * minor adjustment to test_clearsky * undo edit to get_solrad * undo edit to get_solrad * Update pvlib/clearsky.py * Update docs/sphinx/source/whatsnew/v0.11.1.rst * Update docs/sphinx/source/whatsnew/v0.11.1.rst * Update docs/examples/irradiance-transposition/plot_seasonal_tilt.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Revert benchmarks/benchmarks/solarposition.py * Revert test_lookup_linke_turbidity_nointerp * Revert solrad.py * Revert plot_seasonal_tilt.py except notes * Update test_sun_rise_set_transit_spa with delta_t * Update test_nrel_earthsun_distance with delta_t * Update test_sun_rise_set_transit_geometric with naive tz * Update test_hour_angle with inversion and naive tz * Remove _is_leap_year from _interpolate_turbidity * Update docs/sphinx/source/whatsnew/v0.11.1.rst --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…t `pvlib.irradiance` (pvlib#2191) * Update irradiance.py add eqn variable definitions rearrange references changed beta into theta_T to avoid double definition --- surface tilt, and "daily average of the solar elevation in degrees" (pvlib.irradiance.diffuse_par_spitters) * Update irradiance.py * Update irradiance.py Remove Loutzenhiser P.G. et. al. reference. I do not see it cited anywhere here in the docs for the haydavies model * Update irradiance.py add "projection ratio" to variable definition * Update irradiance.py separate A and R_b * Update irradiance.py Change all instances of W/m^2 into Wm⁻² * Update irradiance.py W/m^2 to Wm⁻² * Update irradiance.py * add url to references * Update irradiance.py * unit typesetting suggestion * Update irradiance.py * Update irradiance.py * Update pvlib/irradiance.py Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * eqn typesetting * minor wording edits * Update v0.11.1.rst * Update irradiance.py adjust units Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> * Update irradiance.py * \theta_T -> \beta * add last accessed to reference * remove spurious period * Apply suggestions from code review Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update irradiance.py Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> * Update irradiance.py --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
* Create average_photon_energy.py * Update average_photon_energy.py * Update average_photon_energy.py * Update average_photon_energy.py continuing creation * Update average_photon_energy.py * Update average_photon_energy.py * Update average_photon_energy.py * Update average_photon_energy.py * Update average_photon_energy.py add interpretation of APE values underneath table * Update average_photon_energy.py * Update average_photon_energy.py add ape table * Update average_photon_energy.py add last accessed to references * Update average_photon_energy.py wording, remove table * Update average_photon_energy.py reference order * Apply suggestions from code review Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> * Update average_photon_energy.py * Apply suggestions from code review Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update average_photon_energy.py add = variable names remove unused package * Update average_photon_energy.py gallery example ref * Update v0.11.1.rst * Update docs/sphinx/source/whatsnew/v0.11.1.rst Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> * Update average_photon_energy.py update legend Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --------- Co-authored-by: Ioannis Sifnaios <88548539+IoannisSifnaios@users.noreply.github.com> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
* Remove python version 3.8 * Add py3.9-min * Update min numpy in pyproject.toml * Update asv.conf.json * Update v0.11.1.rst * Update versions in asv.conf.json * Bumping numpy version in asv.conf.json * Update v0.11.1.rst * Update codecov python version * Remove dataclassees in requirements-py3.9-min.yml Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
* Update PVGIS TMY tests and files * Update docs/sphinx/source/whatsnew/v0.11.1.rst
* Update to actions/setup-python@v5 * Update to actions/checkout@v4 * Bring up to pvlib#2218 * Address reviewer comments
* Update irradiance.py move eqn and add description and variables definition to a new notes section update references redefine surface tilt for consistency with pvlib#2191 * Update irradiance.py update variable names (I_d0 to DHI and add definition of theta as aoi) * Update irradiance.py add doi * Update irradiance.py wording in definition of F' * Update irradiance.py * Update irradiance.py \theta->\beta reinstate Loutzenhiser reference * Update irradiance.py add doi to * Update irradiance.py * Update irradiance.py add units to returns statement * typo * Update v0.11.1.rst * Update v0.11.1.rst * update model description * whatsnew, update and merge entries * whatsnew (missing word) * move references (klucher and haydavies) moved references from first line to notes section
* code changes: allow delta_t to be array * initial test updates * whatsnew * lint * fix dtype issue * more delta_t array tests * optimize numba/numpy reloads and warnings * more lint * Update pvlib/spa.py Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * add test with varying delta_t --------- Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* add missing contributors * set release date; misc whatsnew cleanup * more whatsnew cleanup * address review comments Co-Authored-By: RDaxini <143435106+RDaxini@users.noreply.github.com> Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> * tildes --------- Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com> Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
* revise dc_ohmic_loss and dc_ohms_from_percent docstrings * edits * Apply suggestions from code review Thanks @RDaxini Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com> * raw docstring --------- Co-authored-by: RDaxini <143435106+RDaxini@users.noreply.github.com>
* references, variable definition, notes section * Update irradiance.py * Update irradiance.py * Update irradiance.py consistent reference style * Update irradiance.py add date to sentence * R_b definition * Update v0.11.2.rst * Apply suggestions from code review Thanks for the review Co-authored-by: Cliff Hansen <cwhanse@sandia.gov> * extraterrestrial -> direct extraterrestrial as per the paper (variable I_on) * clarify horizontal irradiances definition * theta_T->beta --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Close pvlib#2239 update link to contributing from readme
* Update iam.py * restore comment * remove blank line * Update iam.py * sorry for the rapid commit spam * Apply suggestions from code review Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --------- Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
…deprecation period (pvlib#2237) * Add renamed_kwarg_warning decorator * Example at solarposition.hour_angle() * another day, another test * Flake8 strikes again * Fix no warning test Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Add test to remember removing the deprecation decorator * test-driven-development for the win: unchanged remain properties Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> * Update docs * Update fail_on_pvlib_version test comment * Rename&deprecate solarposition.sun_rise_set_transit_spa * flake8 * flake8 no more * date -> time in solarposition.sun_rise_set_transit_spa * Change to ..versionchanged, same format. * Apply suggestions from Adam Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Apply Adam review x2 Co-Authored-By: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com> * Update solarposition.py * Update solarposition.py * Revert solarposition and test_solarposition changes * Had to use main instead of master xd * 😭 --------- Co-authored-by: Kevin Anderson <57452607+kandersolar@users.noreply.github.com> Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
* Update variables_style_rules.csv * update definition Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> * Update pvlib/data/variables_style_rules.csv Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com> --------- Co-authored-by: Cliff Hansen <5393711+cwhanse@users.noreply.github.com> Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…#2262) * Partially move `test_conftest` to `test__deprecation` * Add no cover directive in a comment * Update v0.11.2.rst
Test cron script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.